[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444277#comment-16444277 ]
ASF GitHub Bot commented on ZOOKEEPER-3007: ------------------------------------------- GitHub user brettKK reopened a pull request: https://github.com/apache/zookeeper/pull/495 ZOOKEEPER-3007:Potential NPE in ReferenceCountedACLCache#deserialize @LJ1043041006 found a potential NPE in ZK ---- callee BinaryInputArchive#startVector will return null: ``` // code placeholder public Index startVector(String tag) throws IOException { int len = readInt(tag); if (len == -1) { return null; } ``` ----- and caller ReferenceCountedACLCache#deserialize call it without null check ``` // code placeholder Index j = ia.startVector("acls"); while (!j.done()) { ACL acl = new ACL(); acl.deserialize(ia, "acl"); } ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/brettKK/zookeeper master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/495.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #495 ---- commit 7d8d5230c5a87faef94d038a258b159a322f3f5e Author: gongleigl.gong <gongleigl.gong@...> Date: 2018-03-26T13:16:06Z d commit 700dfb7f48f774dd215e5bf19340a4b61eda3397 Author: gongleigl.gong <gongleigl.gong@...> Date: 2018-03-27T16:38:28Z fix NPE bug ---- > Potential NPE in ReferenceCountedACLCache#deserialize > ------------------------------------------------------ > > Key: ZOOKEEPER-3007 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3007 > Project: ZooKeeper > Issue Type: Bug > Affects Versions: 3.6.0 > Reporter: lujie > Priority: Major > > Inspired by ZK-3006 , I develop a simple static analysis tool to find other > Potential NPE like ZK-3006. This bug is found by this tool ,and I have > carefully studied it. But i am a newbie at here so i may be wrong, hope > someone could confirm it and help me improve this tool. > h3. Bug describtion: > callee BinaryInputArchive#startVector will return null: > {code:java} > // code placeholder > public Index startVector(String tag) throws IOException { > int len = readInt(tag); > if (len == -1) { > return null; > } > {code} > and caller ReferenceCountedACLCache#deserialize call it without null check > {code:java} > // code placeholder > Index j = ia.startVector("acls"); > while (!j.done()) { > ACL acl = new ACL(); > acl.deserialize(ia, "acl"); > }{code} > but all the other 14 caller of BinaryInputArchive#startVector performs null > checker like: > {code:java} > // code placeholder > Index vidx1 = a_.startVector("acl"); > if (vidx1!= null) > for (; !vidx1.done(); vidx1.incr()){ > ..... > } > } > } > {code} > so i think we also need add null check in caller > ReferenceCountedACLCache#deserialize just like other 14 caller > -- This message was sent by Atlassian JIRA (v7.6.3#76005)