[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports

[enixon]

Github user enixon commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/549#discussion_r198338264
  
    --- Diff: src/java/test/org/apache/zookeeper/test/ReconfigTest.java ---
    @@ -801,10 +801,12 @@ private void testPortChangeToBlockedPort(boolean 
testLeader) throws Exception {
     
         @Test
         public void testUnspecifiedClientAddress() throws Exception {
    -           int[] ports = new int[3];
    -           for (int port : ports) {
    -                   port = PortAssignment.unique();
    -           }
    +           int[] ports = {
    +                PortAssignment.unique(),
    +                PortAssignment.unique(),
    +                PortAssignment.unique()
    +           };
    +
    --- End diff --
    
    is it necessary to make this change?


---