[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports

[enixon]

Github user enixon commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/549#discussion_r198339591
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
---
    @@ -259,6 +259,11 @@ public QuorumServer(long sid, String addressStr) 
throws ConfigException {
                     throw new ConfigException("Address unresolved: " + 
serverParts[0] + ":" + serverParts[2]);
                 }
     
    +            if(addr.getPort() == electionAddr.getPort()) {
    --- End diff --
    
    really happy we're adding this safeguard!


---