Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/561#discussion_r201527825
--- Diff:
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
@@ -817,10 +817,12 @@ protected void pRequest(Request request) throws
RequestProcessorException {
type = OpCode.error;
txn = new ErrorTxn(e.code().intValue());
- LOG.info("Got user-level KeeperException when
processing "
- + request.toString() + " aborting
remaining multi ops."
- + " Error Path:" + e.getPath()
- + " Error:" + e.getMessage());
+ if (e.code().intValue() >
Code.APIERROR.intValue()) {
--- End diff --
I get the point - things will break when they are running at scale :) . I
don't have strong opinion holding this as INFO. wondering how others think
about this (I mentioned it's info as this log was my good friend before when I
debugged some issues...).
BTW for similar use case (large scale of clients) - it looks like all
client side related log should be silenced on server side. basically server
side just keep server specific loggings on by default (which hopefully does not
change regardless of the scale of clients). So all client cnx / session related
logs need be silenced...
---
