Github user enixon commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/561#discussion_r203522048
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
    @@ -754,7 +754,7 @@ public void finishSessionInit(ServerCnxn cnxn, boolean 
valid) {
                 cnxn.sendBuffer(bb);
     
                 if (valid) {
    -                LOG.info("Established session 0x"
    +                LOG.debug("Established session 0x"
    --- End diff --
    
    The attributes of an established connection don't appear in other INFO logs 
but remain accessible through jmx and through ServerCnxn::dumpConnectionInfo 
via 'cons'.
    
    I'd agree with Ben that this is makes parsing the logs hard when the number 
of client connections is high and that it's better to isolate it via log level 
so it can be turned off in that scenario or turned on (via debug) if needed for 
low client-supporting ensembles.


---

Reply via email to