Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/567#discussion_r205933558
  
    --- Diff: 
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
    @@ -102,6 +102,21 @@
         /** Maximum time we allow for elapsed fsync before WARNing */
         private final static long fsyncWarningThresholdMS;
     
    +    /**
    +     * This parameter limit the size of each txnlog to a given limit (KB).
    +     * It does not affect how often the system will take a snapshot 
[zookeeper.snapCount]
    +     * We roll the txnlog when either of the two limits are reached.
    +     * Also since we only roll the logs at transaction boundaries, actual 
file size can exceed
    +     * this limit by the maximum size of a serialized transaction.
    +     * The feature is disabled by default (-1)
    +     */
    +    public static final String LOG_SIZE_LIMIT = 
"zookeeper.txnlogSizeLimitInKb";
    --- End diff --
    
    Yes. This new feature should be documented in zookeeperAdmin. Are you 
planning to address docs here or in separate patch?


---

Reply via email to