Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/622#discussion_r217555258
--- Diff:
src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java ---
@@ -116,6 +120,10 @@ public static Record deserializeTxn(byte txnBytes[],
TxnHeader hdr)
create.setAcl(createv0.getAcl());
create.setEphemeral(createv0.getEphemeral());
create.setParentCVersion(-1);
+ } else if (hdr.getType() == OpCode.closeSession) {
+ // perhaps this is before CloseSessionTxn was added,
--- End diff --
Yes, we do, check the QuorumPeerMainTest.testCloseSessionTxnCompatile, when
leader disabled the CloseSessionTxn, but follower enabled it, we'll hit this.
---
