Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/622#discussion_r217741801
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -1861,6 +1862,76 @@ public void testFaultyMetricsProviderOnConfigure()
throws Exception {
Assert.assertTrue("complains about metrics provider
MetricsProviderLifeCycleException", found);
}
+ /**
+ * Test leader/leader compatibility with/without CloseSessionTxn, so
that
+ * we can gradually rollout this code and rollback if there is problem.
+ */
+ @Test
+ public void testCloseSessionTxnCompatile() throws Exception {
--- End diff --
Using parameterized tests instead?
https://github.com/junit-team/junit4/wiki/parameterized-tests
---