Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/622#discussion_r219104769
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -1861,6 +1862,76 @@ public void testFaultyMetricsProviderOnConfigure()
throws Exception {
Assert.assertTrue("complains about metrics provider
MetricsProviderLifeCycleException", found);
}
+ /**
+ * Test leader/leader compatibility with/without CloseSessionTxn, so
that
+ * we can gradually rollout this code and rollback if there is problem.
+ */
+ @Test
+ public void testCloseSessionTxnCompatile() throws Exception {
--- End diff --
Hm. Okay. I've created a pull request against your repo to visualize how I
think these tests should be refactored:
https://github.com/lvfangmin/zookeeper/pull/1
I understand this looks like overkill in terms of these tests being
temporary, but I think it would be beneficial for the testing side on the long
run.
I also would like to highlight that this is not the expected, final
refactoring of `QuorumPeerMainTest` which will solve all of the related
problems. This is just a small step that I was talking about which could be
safely included into standards PRs like this and leads us to the ideal state of
this big monster.
I'm not telling we should do it this way, just interested in your opinion.
---
