anmolnar commented on a change in pull request #796: ZOOKEEPER-3267: Add
watcher metrics
URL: https://github.com/apache/zookeeper/pull/796#discussion_r256363368
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java
##########
@@ -106,6 +107,7 @@ public void addDeadWatcher(int watcherBit) {
synchronized(processingCompletedEvent) {
processingCompletedEvent.wait(100);
}
+ ServerMetrics.ADD_DEAD_WATCHER_STALL_TIME.add(100);
Review comment:
Good catch @eolivelli . Accuracy of this metric is <100ms now, which we can
improve by measuring the exact time elapsed. I'm not sure either if it's worth
the extra logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
