anmolnar commented on a change in pull request #796: ZOOKEEPER-3267: Add watcher metrics URL: https://github.com/apache/zookeeper/pull/796#discussion_r260708549
########## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/watch/WatcherCleanerTest.java ########## @@ -147,7 +147,7 @@ public void testDeadWatcherMetrics() { Map<String, Object> values = ServerMetrics.getAllValues(); - Assert.assertEquals("Adding dead watcher should be stalled twice", 200L, values.get("add_dead_watcher_stall_time")); + Assert.assertTrue("Adding dead watcher should be stalled twice", (Long)values.get("add_dead_watcher_stall_time") > 0L); Review comment: I believe you can use `greaterThan` matcher here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services