After quickly checking 3.5 has only added two new exitcodes: “unable to access datadir” and “unable to start admin server”, but previous exit codes haven’t been changed.
Between 3.5.x and 3.5.5 I haven’t seen any changes in ExitCodes, however it’s kind of a mess that ExitCode enum has been backported to 3.5 from master, but usages are not! As a consequence most of values in the ExitCode.java are not used in the codebase. Anyway. I don’t see a reason for holding off 3.5.6 due to that BookKeeper issue, although I’d love to see BookKeeper working nicely with ZK 3.5. Regards, Andor > On 2019. Sep 16., at 13:19, Enrico Olivelli <eolive...@gmail.com> wrote: > > Thank you Norbert > > I am investigating a potential problem in ZK 3.5 branch I am seeing in the > upgrade of ZooKeeper in BookKeeper project regarding the exit codes of the > shell (ZooKeeperMain) > > see > https://github.com/apache/bookkeeper/pull/2112#issuecomment-531576441 > > If the problem is there and the fix is a one-liner I will try to submit a > patch before sending the VOTE email for 3.5.6 > > Do you know if we changed the exit code of the CLI from 3.4 and 3.5 ? or > from 3.5-BETA to 3.5.5 ? > > Enrico > > Il giorno lun 16 set 2019 alle ore 12:46 Norbert Kalmar > <nkal...@cloudera.com.invalid> ha scritto: > >> I merged it to master and 3.5 >> Thanks Enrico! >> >> On Sat, Sep 14, 2019 at 5:49 PM Enrico Olivelli <eolive...@gmail.com> >> wrote: >> >>> Too quick: >>> I see we have a "LICENSES" files issue, we changed netty dependency from >>> netty-all to separate bundles. >>> >>> I think we must have separate files, in order to be consistent with other >>> jars >>> >>> I will send a patch soon >>> >>> Enrico >>> >>> -rw-r--r--. 1 eolivelli eolivelli 11366 9 set 18.57 >>> netty-all-4.1.29.Final.LICENSE.txt >>> -rw-r--r--. 1 eolivelli eolivelli 272683 30 ago 19.44 >>> netty-buffer-4.1.29.Final.jar >>> -rw-r--r--. 1 eolivelli eolivelli 316412 30 ago 19.44 >>> netty-codec-4.1.29.Final.jar >>> -rw-r--r--. 1 eolivelli eolivelli 578177 30 ago 19.44 >>> netty-common-4.1.29.Final.jar >>> -rw-r--r--. 1 eolivelli eolivelli 394702 30 ago 19.44 >>> netty-handler-4.1.29.Final.jar >>> -rw-r--r--. 1 eolivelli eolivelli 32275 30 ago 19.44 >>> netty-resolver-4.1.29.Final.jar >>> -rw-r--r--. 1 eolivelli eolivelli 461842 30 ago 19.44 >>> netty-transport-4.1.29.Final.jar >>> -rw-r--r--. 1 eolivelli eolivelli 115477 30 ago 19.44 >>> netty-transport-native-epoll-4.1.29.Final.jar >>> -rw-r--r--. 1 eolivelli eolivelli 31171 30 ago 19.44 >>> netty-transport-native-unix-common-4.1.29.Final.jar >>> >>> Il giorno sab 14 set 2019 alle ore 16:42 Enrico Olivelli < >>> eolive...@gmail.com> ha scritto: >>> >>>> branch-3.5.6 is good to go now. >>>> I am preparing the release artifacts now. >>>> >>>> I hope I won't find any other show stopper on my way >>>> >>>> Enrico >>>> >>>> Il giorno ven 6 set 2019 alle ore 17:45 Enrico Olivelli < >>>> eolive...@gmail.com> ha scritto: >>>> >>>>> Hi, >>>>> I have moved all of the pending issue for 3.5.6 to 3.5.7. >>>>> >>>>> I did not have the flag "do not send email", I hope I have not >> generated >>>>> too much spam >>>>> >>>>> Enrico >>>>> >>>>> >>>>> Il giorno lun 2 set 2019 alle ore 01:50 Patrick Hunt < >> ph...@apache.org> >>>>> ha scritto: >>>>> >>>>>> Thanks for driving this Enrico. I created 3.5.7 version in JIRA to >>>>>> facilitate. LMK if there's more that you need. >>>>>> >>>>>> Patrick >>>>>> >>>>>> On Fri, Aug 30, 2019 at 10:59 AM Enrico Olivelli < >> eolive...@gmail.com> >>>>>> wrote: >>>>>> >>>>>>> Can any PMC create the 3.5.7 version on JIRA please ? >>>>>>> >>>>>>> I have to move all of the issues targeted 3.5.6 to that version. >>>>>>> >>>>>>> IMHO we should not target issues directly to 3.5 branch if not >>> strictly >>>>>>> needed. >>>>>>> We have a lot of issues, 181, targeted to 3.5.6 and not resolved. >>>>>>> >>>>>>> This is my search >>>>>>> >>>>>>> >>>>>> >>> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20ZOOKEEPER%20AND%20fixversion%3D3.5.6%20and%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC >>>>>>> >>>>>>> >>>>>>> We should retarget them to 3.6.0 or clear the fixVersion attribute. >>>>>>> You cannot set "fixVersion" if you do not intend to provide a >> patch, >>>>>> can >>>>>>> you ? >>>>>>> >>>>>>> Enrico >>>>>>> >>>>>>> Il giorno ven 30 ago 2019 alle ore 19:11 Enrico Olivelli < >>>>>>> eolive...@gmail.com> ha scritto: >>>>>>> >>>>>>>> I am preparing for the release. >>>>>>>> It is the first time for me so I have to setup a bunch of things, >>>>>> like >>>>>>> GPG >>>>>>>> KEYS..... >>>>>>>> >>>>>>>> The procedure (1) is very detailed, I hope I won't encounter >> issues >>>>>>>> >>>>>>>> I am not sure I will be able to be ready for a VOTE tonight. >>>>>>>> I hope I will be able to prepare a good RC during the weekend >>>>>>>> >>>>>>>> Enrico >>>>>>>> >>>>>>>> (1) >>>>>>>> >>>>>>> >>>>>> >>> >> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease+using+maven >>>>>>>> >>>>>>>> Il giorno ven 30 ago 2019 alle ore 13:43 Enrico Olivelli < >>>>>>>> eolive...@gmail.com> ha scritto: >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Il ven 30 ago 2019, 02:56 Brian Nixon <brian.nixon...@gmail.com >>> >>> ha >>>>>>>>> scritto: >>>>>>>>> >>>>>>>>>> I agree that ZOOKEEPER-3056 would be super nice to have in >> 3.5.6. >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Does anyway want to pick it up? I can want until early next >> week. >>>>>>>>> Otherwise I will start tonight (within 6-7 hours) >>>>>>>>> >>>>>>>>> Enrico >>>>>>>>> >>>>>>>>> >>>>>>>>>> Don't know what shape the solution should be but don't think it >>>>>>> requires >>>>>>>>>> that much code - just thinking and community agreement. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Thu, Aug 29, 2019 at 4:31 PM Michael Han <h...@apache.org> >>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> ZOOKEEPER-3056 would be nice to have, I'll try to have a >> patch >>>>>> ready >>>>>>>>>> soon, >>>>>>>>>>> but it's not a blocker given workarounds available (unless >>>>>> community >>>>>>>>>> votes >>>>>>>>>>> we really need this for 3.5.6). >>>>>>>>>>> >>>>>>>>>>> On Thu, Aug 29, 2019 at 8:16 AM Zili Chen < >>> wander4...@gmail.com> >>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> Great! >>>>>>>>>>>> >>>>>>>>>>>> IIRC it is possible to add a customized kanban on JIRA >> site, >>>>>>>>>>> specifically, >>>>>>>>>>>> to track all issues marked as "blocker" and to the target >>>>>> release. >>>>>>>>>> If we >>>>>>>>>>>> make use of that we can ensure no blockers before released. >>>>>>>>>>>> >>>>>>>>>>>> Best, >>>>>>>>>>>> tison. >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Andor Molnar <an...@cloudera.com.invalid> 于2019年8月29日周四 >>>>>> 下午10:47写道： >>>>>>>>>>>> >>>>>>>>>>>>> Great +1 >>>>>>>>>>>>> >>>>>>>>>>>>> On Thu, Aug 29, 2019 at 4:37 PM Enrico Olivelli < >>>>>>>>>> eolive...@gmail.com> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Hello, >>>>>>>>>>>>>> I am going to cut 3.5.6, if you have patches to cherry >>>>>> pick or >>>>>>>>>> you >>>>>>>>>>> are >>>>>>>>>>>>>> aware of blocker issues for such release please tell me >>> as >>>>>> soon >>>>>>>>>> as >>>>>>>>>>>>>> possible. >>>>>>>>>>>>>> >>>>>>>>>>>>>> I will start the procedure tomorrow >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Enrico >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>> >>>>>> >>>>> >>> >>
