---------- Forwarded message --------- Da: Andor Molnar <an...@apache.org> Date: lun 13 gen 2020, 13:05 Subject: Re: ZooKeeper 3.6.0 rc 0 failed To: DevZooKeeper <dev@zookeeper.apache.org>
Thank you Andor I will continue the procedure adapting it to the zip file. Anyone would be allowed to cast a -1 on the VOTE thread I will send a pr for the removal of the useless tarbal from the build Enrico This ZIP is good. I verified and the executable bits are correct, there’s nothing wrong with that. (for some reason ClientCnxnSocketNetty.java is executable) +1 for using this artifact in 3.6.0 Andor > On 2020. Jan 13., at 11:54, Enrico Olivelli <eolive...@gmail.com> wrote: > > Il giorno lun 13 gen 2020 alle ore 10:47 Andor Molnar <an...@apache.org> ha > scritto: > >> I’ve done a quick check on my Mac and “zip” and “unzip” command line tools >> are able to preserve the standard ‘rwx’ permissions which is probably >> enough. The rest (uid/gid/setuid/setgid/etc.) of the flags are probably not >> important. >> >> We should take a quick look at the artifact which the ASF Maven file >> generates and if it works as above, I’m happy with doing the change for >> 3.6.0. >> > > The staged ZIP artifacts are here: > http://home.apache.org/~eolivelli/zookeeper-3.6.0-candidate-0/ > > The ZIP file is the perfect copy of the git tag, I have compared them with > meld > > Enrico > > >> >> Andor >> >> >> >>> On 2020. Jan 12., at 22:02, Enrico Olivelli <eolive...@gmail.com> wrote: >>> >>> Il dom 12 gen 2020, 21:53 Andor Molnar <an...@apache.org> ha scritto: >>> >>>> Hi Enrico, >>>> >>>> That sounds cool, but why zip? >>>> >>> >>> >>> I don't know the reason, but in Maven central sources are deployed as >> zip, >>> maybe because it is better supported on all platforms and it is the same >> as >>> the jar format. >>> >>> Afaik zip cannot archive unix permissions which could make the C client >>>> a mess. Would you please check that? >>>> >>> >>> I will check again, but the c clients builds correctly. >>> >>> If our users are used to the tar.gz format I feel it is not time to >> change >>> it, we can do the switch in 3.7.0 >>> >>> The only bad fact is that maintaining the current assembly descriptor is >>> complicated, but we can live with it for 3.6.0. >>> >>> This is why I am asking, in order to see the options in our community >>> >>> Hopefully now that the community is more alive we will have more releases >>> and we can change more quickly >>> >>> Enrico >>> >>> >>>> Andor >>>> >>>> >>>> >>>> On Sat, 2020-01-11 at 23:33 +0100, Enrico Olivelli wrote: >>>>> I have fresh news >>>>> while working on the issue >>>>> https://issues.apache.org/jira/browse/ZOOKEEPER-3695 >>>>> >>>>> I saw that Maven already did a better way automatically other then >>>>> what we >>>>> were trying to achieve with the maven-assembly-plugin >>>>> >>>>> By default using the Apache Maven Parent Pom (we are using it as we >>>>> are an >>>>> ASF project) Maven creates a "sources" zip and this package is a >>>>> perfect >>>>> copy of the git repository during the release process. >>>>> >>>>> I have addeded in the staging directory the zip file, signature and >>>>> the >>>>> sha512 hash (already created during the automatic release procedure) >>>>> http://home.apache.org/~eolivelli/zookeeper-3.6.0-candidate-0/ >>>>> >>>>> If we agree on changing the format of the "source release" from >>>>> tar.gz to >>>>> zip then the staged rc is good for a VOTE and it is perfectly >>>>> integrated >>>>> with the Maven release procedure. >>>>> >>>>> Thoughts ? >>>>> >>>>> Enrico >>>>> >>>>> >>>>> >>>>> >>>>> Il giorno sab 11 gen 2020 alle ore 22:54 Enrico Olivelli < >>>>> eolive...@gmail.com> ha scritto: >>>>> >>>>>> Hi, >>>>>> I was preparing the first rc of 3.6.0 but unfortunately it failed >>>>>> as I >>>>>> have found a blocker issue >>>>>> >>>>>> This is the issue >>>>>> https://issues.apache.org/jira/browse/ZOOKEEPER-3695 >>>>>> >>>>>> The short version of the story is that the source tarbal does not >>>>>> reflect >>>>>> the git repository, some directories are missing and there is some >>>>>> curn in >>>>>> the c client. >>>>>> >>>>>> I am working on a fix >>>>>> >>>>>> Meanwhile....if you have cycles it would be very helpful if you >>>>>> take a >>>>>> look to the staged artifacts of 3.6.0-rc0. >>>>>> >>>>>> you can find them here: >>>>>> http://home.apache.org/~eolivelli/zookeeper-3.6.0-candidate-0/ >>>>>> >>>>>> the Maven staging repository is; >>>>>> >>>> >> https://repository.apache.org/content/repositories/orgapachezookeeper-1045 >>>>>> >>>>>> I won't call for a vote for 3.6.0-rc0. >>>>>> >>>>>> The first call will be for 3.6.0-rc1 as I have already created a >>>>>> tag for >>>>>> release-3.6.0-0 and I don't want to mess up the repository of >>>>>> anyone who >>>>>> already "git fetched" the tag. >>>>>> https://github.com/apache/zookeeper/commits/release-3.6.0-0 >>>>>> >>>>>> Stay tuned >>>>>> >>>>>> Enrico >>>>>> >>>>>> >>>> >>>> >> >>
