"they actually link to a deleted ci job I created a few days ago to test the new CI system.”
Oh, I see now. Sorry, missed this part. So, actually you broke them. I’m glad that’s not something I’ve messed up. :) Andor > On 2020. Sep 15., at 23:19, Michael Han <h...@apache.org> wrote: > > Hi Andor, > > Here are a set of concrete examples of the dead links of the pre-merge jobs: > https://github.com/apache/zookeeper/pull/1433 > https://github.com/apache/zookeeper/pull/1438 > https://github.com/apache/zookeeper/pull/1441 > > The old link I posted ( > https://ci-hadoop.apache.org/view/ZooKeeper/job/zookeeper-precommit-github-pr/view/change-requests/job/PR-1380/) > is good now, because I manually triggered the job yesterday :] > > I think these broken links are fixable as we can trigger pre-merge jobs for > them, it's just tedious through the UI one by one as I haven't found a good > way to batch trigger pre-commit for all pull requests. > > Also, as I just tested, it seems a user can just close and reopen the pull > request to trigger the pre-merge job (although last time I tested this, it > failed to trigger). So this can be a work around for contributors before > the trigger phrase (if any) is ready. > > Again thanks for taking time working on getting CI back to good shape! > > On Tue, Sep 15, 2020 at 12:55 PM Andor Molnar <an...@apache.org> wrote: > >> Hi Michael, >> >> I was working on the CI migration and there’re still a few things which is >> not available in the new system. I haven’t found any solution for the >> “retest” trigger, but I’ll take another look tomorrow. I need to dig the >> builds@ list if there’s anything happened since I’ve last checked e.g. >> new plugins installed, etc. >> >> I’m not sure I understand your concern about dead links. Here’s the link >> of the pre-commit job for your PR: >> >> https://ci-hadoop.apache.org/view/ZooKeeper/job/zookeeper-precommit-github-pr/view/change-requests/job/PR-1380/ >> >> From the Github PR page I can see the following link: >> >> https://ci-hadoop.apache.org/blue/organizations/jenkins/zookeeper-precommit-github-pr/detail/PR-1380/4/pipeline >> >> Which takes me to the Pipeline Report and definitely not dead. (This must >> be some new thing, but looks quite cool.) >> >> OWASP Build - Good point Patrick, that’s still missing. >> I’ve created the branch and PreCommit jobs as Jenkins pipelines, nicely >> committed and tracked in Git. I believe that’s how we should do CI in the >> future. But I was reluctant do the same with flaky-test job which is just a >> copy-and-paste Jenkins job atm. >> >> Feel free to choose your way for the Owasp build, if you’re willing to >> migrate it, but I think at the end of the way we should have everything in >> source control to be perfect. >> >> We still don’t have Windows build either, but I’m not sure if >> Windows-based nodes are available. >> >> Andor >> >> >> >>> On 2020. Sep 13., at 23:02, Michael Han <h...@apache.org> wrote: >>> >>> Folks, >>> >>> I am seeing some CI build issues. Specifically: >>> >>> * Comment on github PR with "retest maven build" does not trigger a >> rebuild >>> of JenkinsMaven. This used to work. Is this a known issue? >>> >>> * Tons of pre-merge job links on PRs are broken: they actually link to a >>> deleted ci job I created a few days ago to test the new CI system. Here >> is >>> a broken link >>> < >> https://ci-hadoop.apache.org/job/zookeeper_hanm_tests/job/PR-1380/1/display/redirect >>> >>> for reference. Do we know how we can trigger a new pre-merge job on >>> existing PRs so these links can be fixed? >> >>
