Hi Máté, Enrico, all,

Thank you for the check.

3.6.2 was okay.

It appears to be an issue with maven-assembly-plugin and the descriptor
used for the source bundle.

This is the second issue I spot which is related to ZOOKEEPER-3833, "Do
Not Override Plugin Versions from Apache Parent POM."  (I very much
agree in principle, but that ground seems a bit shaky :)

Reverting to version 3.1.0 makes the issue disappear:

    --- a/pom.xml
    +++ b/pom.xml
    @@ -690,6 +690,7 @@
             <plugin>
               <groupId>org.apache.maven.plugins</groupId>
               <artifactId>maven-assembly-plugin</artifactId>
    +          <version>3.1.0</version>
             </plugin>
             <plugin>
               <groupId>org.apache.maven.plugins</groupId>

I haven't investigated further, but will have a closer look soon.

Cheers (well…), -D

P.-S. — Thank you Justin for filing ZOOKEEPER-4188.



Enrico Olivelli <eolive...@gmail.com> writes:
> Mate,
> Thanks foe pointing it out
> If you build from sources and you pick the rwsulting binaries tarball and
> unpack it, does it work?
> Running bin/ex.sh from the sources is probably only a developer feature and
> it does not impact production usage.
>
> Is the problem present even on 3.6.2?
>
> Enrico
>
> Il Sab 23 Gen 2021, 17:13 Szalay-Bekő Máté <szalay.beko.m...@gmail.com> ha
> scritto:
>
>> I just ran a few small manual upgrade tests, 3.5.9 -> 3.7.0 and 3.6.2 ->
>> 3.7.0) using https://github.com/symat/zk-rolling-upgrade-test
>> Both tests succeeded (which is great! :) ), however I had to do a manual
>> fix: my test scripts were unable to start the 3.7.0 servers,
>> because zkServer.sh didn't have execute permissions.
>>
>> It looks this is only about the source tar.gz release file (which is our
>> main deliverable). When I downloaded the binary tar.gz file, or checked out
>> the release tag, then the files had the execution tag. See below.
>>
>> I don't know if this is officially a blocker or not, PMC members please
>> advise here.
>> (my non-binding opinion is that this is a blocker unfortunately...)
>>
>> Regards,
>> Mate
>>
>> More info:
>>
>> $  git clone --depth 1 --branch release-3.7.0-0 g...@github.com:
>> apache/zookeeper.git
>> $  ls -la zookeeper/bin/*.sh
>> -rwxr-xr-x 1 symat symat  2066 Jan 23 16:58 zookeeper/bin/zkCleanup.sh
>> -rwxr-xr-x 1 symat symat  1620 Jan 23 16:58 zookeeper/bin/zkCli.sh
>> -rwxr-xr-x 1 symat symat  3690 Jan 23 16:58 zookeeper/bin/zkEnv.sh
>> -rwxr-xr-x 1 symat symat  4559 Jan 23 16:58
>> zookeeper/bin/zkServer-initialize.sh
>> -rwxr-xr-x 1 symat symat 11561 Jan 23 16:58 zookeeper/bin/zkServer.sh
>> -rwxr-xr-x 1 symat symat  1377 Jan 23 16:58
>> zookeeper/bin/zkSnapShotToolkit.sh
>> -rwxr-xr-x 1 symat symat  1374 Jan 23 16:58
>> zookeeper/bin/zkSnapshotComparer.sh
>> -rwxr-xr-x 1 symat symat  1385 Jan 23 16:58
>> zookeeper/bin/zkTxnLogToolkit.sh
>>
>> $ wget
>>
>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-0/apache-zookeeper-3.7.0-bin.tar.gz
>> $ tar xzvf  apache-zookeeper-3.7.0-bin.tar.gz
>> $ ls -la apache-zookeeper-3.7.0-bin/bin/*.sh
>> -rwxr-xr-x 1 symat symat  2066 Jan 22  2020
>> apache-zookeeper-3.7.0-bin/bin/zkCleanup.sh
>> -rwxr-xr-x 1 symat symat  1620 Jan 22  2020
>> apache-zookeeper-3.7.0-bin/bin/zkCli.sh
>> -rwxr-xr-x 1 symat symat  3690 Jan 22  2020
>> apache-zookeeper-3.7.0-bin/bin/zkEnv.sh
>> -rwxr-xr-x 1 symat symat  4559 Jan 22  2020
>> apache-zookeeper-3.7.0-bin/bin/zkServer-initialize.sh
>> -rwxr-xr-x 1 symat symat 11561 Jan 22  2020
>> apache-zookeeper-3.7.0-bin/bin/zkServer.sh
>> -rwxr-xr-x 1 symat symat  1377 Jan 22  2020
>> apache-zookeeper-3.7.0-bin/bin/zkSnapShotToolkit.sh
>> -rwxr-xr-x 1 symat symat  1374 Jan 22  2020
>> apache-zookeeper-3.7.0-bin/bin/zkSnapshotComparer.sh
>> -rwxr-xr-x 1 symat symat  1385 Jan 22  2020
>> apache-zookeeper-3.7.0-bin/bin/zkTxnLogToolkit.sh
>>
>> $ wget
>>
>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-0/apache-zookeeper-3.7.0.tar.gz
>> $ tar xzvf  apache-zookeeper-3.7.0.tar.gz
>> $ ls -la apache-zookeeper-3.7.0/bin/*.sh
>> -rw-r--r-- 1 symat symat  2066 Jan 22  2020
>> apache-zookeeper-3.7.0/bin/zkCleanup.sh
>> -rw-r--r-- 1 symat symat  1620 Jan 22  2020
>> apache-zookeeper-3.7.0/bin/zkCli.sh
>> -rw-r--r-- 1 symat symat  3690 Jan 22  2020
>> apache-zookeeper-3.7.0/bin/zkEnv.sh
>> -rw-r--r-- 1 symat symat  4559 Jan 22  2020
>> apache-zookeeper-3.7.0/bin/zkServer-initialize.sh
>> -rw-r--r-- 1 symat symat 11561 Jan 22  2020
>> apache-zookeeper-3.7.0/bin/zkServer.sh
>> -rw-r--r-- 1 symat symat  1377 Jan 22  2020
>> apache-zookeeper-3.7.0/bin/zkSnapShotToolkit.sh
>> -rw-r--r-- 1 symat symat  1374 Jan 22  2020
>> apache-zookeeper-3.7.0/bin/zkSnapshotComparer.sh
>> -rw-r--r-- 1 symat symat  1385 Jan 22  2020
>> apache-zookeeper-3.7.0/bin/zkTxnLogToolkit.sh
>>
>>
>> On Sat, Jan 23, 2021 at 4:32 AM Patrick Hunt <ph...@apache.org> wrote:
>>
>> > On Fri, Jan 22, 2021 at 6:55 PM Justin Ling Mao <
>> maoling199210...@sina.com
>> > >
>> > wrote:
>> >
>> > > I create the ticket: ZOOKEEPER-4188: add a doc about whoami CLI for me
>> to
>> > > do. It's not a blocker. Let's go ahead:)
>> > >
>> > >
>> > Thanks Justin. Note that a release can't be vetoed (also I did give
>> > a +1) and as the RM Damien should make the final decision on the
>> > seriousness of any issues found. Perhaps a good opportunity to review the
>> > apache release voting guidelines:
>> > https://www.apache.org/foundation/voting.html#ReleaseVotes
>> > http://www.apache.org/legal/release-policy.html#release-approval
>> >
>> > Regards,
>> >
>> > Patrick
>> >
>> >
>> > > ----- Original Message -----
>> > > From: Patrick Hunt <ph...@apache.org>
>> > > To: DevZooKeeper <dev@zookeeper.apache.org>
>> > > Subject: Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 0
>> > > Date: 2021-01-23 05:09
>> > >
>> > > +1 - xsum/sig validated. Compiles/runs fine on macos+jdk11. Verified
>> some
>> > > larger ensemble sizes manually and it worked ok.
>> > > I looked at a few of the new features listed - they look great! I did
>> > > notice some changes without documentation though (whoami eg), would be
>> > good
>> > > for committers to ensure that docs get updated along the way...
>> > > Thanks Damien for acting as RM. Regards,
>> > > Patrick
>> > > On Tue, Jan 19, 2021 at 4:40 AM Damien Diederen <ddiede...@apache.org>
>> > > wrote:
>> > > >
>> > > > Dear all,
>> > > >
>> > > > This is a first release candidate for ZooKeeper 3.7.0.
>> > > >
>> > > > It introduces a number of new features, notably:
>> > > >
>> > > >   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>> > > >
>> > > >   * Quota enforcement (ZOOKEEPER-3301);
>> > > >
>> > > >   * Host name canonicalization in quorum SASL authentication
>> > > > (ZOOKEEPER-4030);
>> > > >
>> > > >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>> > > >
>> > > >   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>> > > >
>> > > >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>> > > >
>> > > >   * The possibility of disabling digest authentication
>> > (ZOOKEEPER-3979);
>> > > >
>> > > >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>> > > >
>> > > >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>> > > >
>> > > >   * Additional security metrics (ZOOKEEPER-3978);
>> > > >
>> > > >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
>> > > > ZOOKEEPER-3714);
>> > > >
>> > > >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>> > > >
>> > > >   * Notes on how to benchmark ZooKeeper with the YCSB tool
>> > > > (ZOOKEEPER-3264).
>> > > >
>> > > > The release notes are available here:
>> > > >
>> > > >
>> > > >
>> > >
>> >
>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-0/website/releasenotes.html
>> > > >
>> > > >
>> > >
>> >
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
>> > > >
>> > > > *** Please download, test and vote by January 24th 2020, 23:59 UTC+0.
>> > ***
>> > > >
>> > > > Source files:
>> > > >
>> > > >   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-0/
>> > > >
>> > > > Maven staging repo:
>> > > >
>> > > >
>> > > >
>> > >
>> >
>> https://repository.apache.org/content/repositories/orgapachezookeeper-1065/
>> > > >
>> > > > The release candidate tag in git to be voted upon: release-3.7.0-0
>> > > >
>> > > >   https://github.com/apache/zookeeper/tree/release-3.7.0-0
>> > > >
>> > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>> > > >
>> > > >   https://www.apache.org/dist/zookeeper/KEYS
>> > > >
>> > > > The staging version of the website is:
>> > > >
>> > > >
>> > > >
>> > >
>> >
>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-0/website/
>> > > >
>> > > > Should we release this candidate?
>> > > >
>> > > > Damien Diederen
>> > > >
>> > > >
>> > >
>> >
>>

Reply via email to