Hey all, I know that with all the release discussions and logging framework updates things have been really busy. It's been ~3 weeks or so, so I just wanted to follow up since this is a pretty large pull request from me. Is there anything else I could supply that would make it easier to review (e.g. design documentation, a video of demo usage, etc.)? I appreciate everyone's time is valuable and limited and I'd like to help make this PR as painless as possible, so I don't mind doing more if it would help you all.
Thanks! ~Brent On Mon, Jan 10, 2022 at 4:14 PM Brent <brentwritesc...@gmail.com> wrote: > Sounds great! Thank you Enrico and please reach out via email or on the > PR if I can answer any questions. > > ~Brent > > On Mon, Jan 10, 2022 at 1:19 PM Enrico Olivelli <eolive...@gmail.com> > wrote: > >> Brent, >> Thank you very much >> >> I will review your patches tomorrow. >> >> It is great to move forward with this tool >> >> Enrico >> >> >> Il Lun 10 Gen 2022, 19:38 Brent <brentwritesc...@gmail.com> ha scritto: >> >> > Hi everyone, >> > >> > I just submitted a fairly big PR targeted at the ZooInspector contrib >> > project: https://github.com/apache/zookeeper/pull/1796 >> > >> > I'm not sure how many people use ZooInspector or how well maintained it >> has >> > been, but I have been getting some value out of it and had submitted a >> > couple fixes previously: >> > >> > https://github.com/apache/zookeeper/pull/1551 >> > https://github.com/apache/zookeeper/pull/1601 >> > >> > My biggest remaining issue has been performance. When using it over a >> > network to a remote Zookeeper cluster, especially with many ZNodes, it >> has >> > been almost unusably slow. In my testing, the changes I just >> > submitted seem to fix a lot of these issues. >> > >> > Since Exhibitor (https://github.com/soabase/exhibitor) hasn't received >> an >> > update since 2018, I was hoping to put some more effort back into making >> > ZooInspector a bit more widely usable again. >> > >> > I wanted to send a note to this mailing list in case it warranted >> further >> > discussion since I know it's a substantial change and I haven't been a >> very >> > frequent contributor up to this point. >> > >> > Thank you! >> > >> > ~Brent >> > >> >
