It is a good patch to move forward with the protocol evolution. Please any reviewer take time to validate the patch
Enrico Il giorno mar 29 mar 2022 alle ore 10:17 tison <wander4...@gmail.com> ha scritto: > > The corresponding JIRA is filed as ZOOKEEPER-4492 and @eolivelli has given > a review & approval. > > This patch is looking for another committers for reviewing and I'd like to > bump this thread requesting for review :) > > Best, > tison. > > > tison <wander4...@gmail.com> 于2022年3月13日周日 11:17写道： > > > I'm trying to introduce an abstraction here[1]. Please review and if it's > > in the right direction, > > I'll create a ticket and move forward. > > > > Best, > > tison. > > > > [1] https://github.com/apache/zookeeper/pull/1837 > > > > > > tison <wander4...@gmail.com> 于2022年3月3日周四 11:38写道： > > > >> > if there is a way to detect ... > >> > >> I think it's possible but losing the purpose we merge the readonly field. > >> > >> For example, we can still catch an exception and go into another code > >> path, > >> but in any approach we detect a different version of client, the only > >> difference > >> of these two protocol is about how to write connect {request|response}. > >> And > >> thus we actually do something as we do now. > >> > >> But if we can factor out a protocol interface it may be worth to give it > >> a try, > >> as if we still want to continue ZOOKEEPER-102, there will be such a > >> protocol > >> interface and switch abstraction. > >> > >> Best, > >> tison. > >> > >> > >> Enrico Olivelli <eolive...@gmail.com> 于2022年3月2日周三 00:07写道： > >> > >>> Il giorno mar 1 mar 2022 alle ore 16:32 tison <wander4...@gmail.com> ha > >>> scritto: > >>> > > >>> > ... and this is the main PR: > >>> https://github.com/apache/zookeeper/pull/1832 > >>> > > >>> > However, it seems that ZK 3.3.x may be broken and the jute protocol > >>> cannot > >>> > cover the case. You can review the PR and I already commented details. > >>> > >>> I have seen the patch. Good work! > >>> > >>> I wonder if there is a way to detect that we are talking with a old > >>> client and use a different version of the protocol. > >>> > >>> Dropping compatibility to 3.3 is not so bad, I assume that most of the > >>> users are on 3.4+ currently > >>> > >>> That said, if we can still be compatible it will be far better, > >>> ZooKeeper has a strong tradition of being compatible and we should > >>> break this only if strictly needed, > >>> that is the benefit of breaking compatibility is bigger than the pain > >>> > >>> Enrico > >>> > >>> > >>> > > >>> > Best, > >>> > tison. > >>> > > >>> > > >>> > tison <wander4...@gmail.com> 于2022年2月28日周一 09:33写道： > >>> > > >>> > > Hi, > >>> > > > >>> > > Thanks for eolivelli's review and approval, this PR[1] is waiting for > >>> > > another reviewer to proceed. I'd like to bump this thread to see if > >>> any > >>> > > committer could help on reviewing :) > >>> > > > >>> > > Best, > >>> > > tison. > >>> > > > >>> > > [1] https://github.com/apache/zookeeper/pull/1826 > >>> > > > >>> > > > >>> > > Enrico Olivelli <eolive...@gmail.com> 于2022年2月24日周四 23:20写道： > >>> > > > >>> > >> Tison > >>> > >> > >>> > >> Il Gio 24 Feb 2022, 15:29 tison <wander4...@gmail.com> ha scritto: > >>> > >> > >>> > >> > Here is an initial PR[1] you can give a review. I think the > >>> script is > >>> > >> > enough for the original purpose merging readOnly field. > >>> > >> > > >>> > >> > >>> > >> Very good > >>> > >> I left one comment > >>> > >> > >>> > >> > >>> > >> > >>> > >> Enrico > >>> > >> > >>> > >> > >>> > >> > >>> > >> > Best, > >>> > >> > tison. > >>> > >> > > >>> > >> > [1] https://github.com/apache/zookeeper/pull/1826 > >>> > >> > > >>> > >> > > >>> > >> > Enrico Olivelli <eolive...@gmail.com> 于2022年2月23日周三 20:46写道： > >>> > >> > > >>> > >> > > Il Mer 23 Feb 2022, 10:46 tison <wander4...@gmail.com> ha > >>> scritto: > >>> > >> > > > >>> > >> > > > Hi Enrico, > >>> > >> > > > > >>> > >> > > > Thanks for your reply! Do we have end to end tests for the > >>> same > >>> > >> version > >>> > >> > > of > >>> > >> > > > client and server now? > >>> > >> > > > > >>> > >> > > > >>> > >> > > We haven't. > >>> > >> > > We only use the local code to run both the client and the server > >>> > >> > > > >>> > >> > > Enrico > >>> > >> > > > >>> > >> > > > >>> > >> > > If we already have such tests, then wrapping them among > >>> different > >>> > >> > versions > >>> > >> > > > is possible. Otherwise, > >>> > >> > > > we may add such end to end tests first XD > >>> > >> > > > > >>> > >> > > > Best, > >>> > >> > > > tison. > >>> > >> > > > > >>> > >> > > > > >>> > >> > > > Enrico Olivelli <eolive...@gmail.com> 于2022年2月22日周二 02:14写道： > >>> > >> > > > > >>> > >> > > > > I missed this thread. > >>> > >> > > > > If you manage to keep full compatibility with old clients > >>> then I > >>> > >> am > >>> > >> > +1 > >>> > >> > > > > > >>> > >> > > > > We are missing compatibility tests, it may be a good time > >>> to start > >>> > >> > such > >>> > >> > > > > suite. > >>> > >> > > > > We can start by running the client (bash cli) in a docker > >>> > >> container > >>> > >> > > > > probably. > >>> > >> > > > > > >>> > >> > > > > > >>> > >> > > > > Enrico > >>> > >> > > > > > >>> > >> > > > > Il Lun 21 Feb 2022, 17:47 tison <wander4...@gmail.com> ha > >>> > >> scritto: > >>> > >> > > > > > >>> > >> > > > > > Bump the thread for one last try to see if any zookeeper > >>> is > >>> > >> > > interested > >>> > >> > > > in > >>> > >> > > > > > this topic. > >>> > >> > > > > > > >>> > >> > > > > > Best, > >>> > >> > > > > > tison. > >>> > >> > > > > > > >>> > >> > > > > > >>> > >> > > > > >>> > >> > > > >>> > >> > > >>> > >> > >>> > > > >>> > >>
