Reviewed-by: Ray Ni <[email protected]> > -----Original Message----- > From: [email protected] [mailto:[email protected]] On Behalf Of > Ard Biesheuvel > Sent: Sunday, April 14, 2019 12:52 PM > To: [email protected] > Cc: Ard Biesheuvel <[email protected]>; Kinney, Michael D > <[email protected]>; Andrew Fish <[email protected]>; Leif > Lindholm <[email protected]>; Zeng, Star <[email protected]>; > Dong, Eric <[email protected]>; Ni, Ray <[email protected]>; Gao, Liming > <[email protected]>; Carsey, Jaben <[email protected]>; Shi, > Steven <[email protected]>; Wang, Jian J <[email protected]>; Wu, > Hao A <[email protected]> > Subject: [edk2-devel] [PATCH v6 3/7] MdeModulePkg/PciBusDxe: dispatch > option ROMs for foreign architectures > > Delete the explicit machine type check for option ROM images, and instead, > rely on the LoadImage() boot service to decide whether an option ROM can > be dispatched or not. This permits platforms to ship with emulators to > execute option ROMs that are not native to the processor architecture. > > Signed-off-by: Ard Biesheuvel <[email protected]> > Reviewed-by: Michael D Kinney <[email protected]> > --- > MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c > index c75ef1a82505..54cf4251cc86 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c > @@ -699,13 +699,6 @@ ProcessOpRomImage ( > goto NextImage; > } > > - // > - // Skip the EFI PCI Option ROM image if its machine type is not > supported > - // > - if (!EFI_IMAGE_MACHINE_TYPE_SUPPORTED (EfiRomHeader- > >EfiMachineType)) { > - goto NextImage; > - } > - > // > // Ignore the EFI PCI Option ROM image if it is an EFI application > // > -- > 2.17.1 > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39121): https://edk2.groups.io/g/devel/message/39121 Mute This Topic: https://groups.io/mt/31133142/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
