On 06/12/19 04:39, Gao, Zhichao wrote: > From: Bret Barkelew <bret.barke...@microsoft.com> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1900 > > Add the lacking instance to [Componnets] of dsc file > for build only. > > Cc: Jian Wang <jian.j.w...@intel.com> > Cc: Ting Ye <ting...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Cc: Sean Brogan <sean.bro...@microsoft.com> > Cc: Michael Turner <michael.tur...@microsoft.com> > Cc: Bret Barkelew <bret.barke...@microsoft.com> > Signed-off-by: Zhichao Gao <zhichao....@intel.com> > --- > CryptoPkg/CryptoPkg.dsc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/CryptoPkg/CryptoPkg.dsc b/CryptoPkg/CryptoPkg.dsc > index 9dfa349f6d..c90e76c721 100644 > --- a/CryptoPkg/CryptoPkg.dsc > +++ b/CryptoPkg/CryptoPkg.dsc > @@ -116,6 +116,7 @@ > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > CryptoPkg/Library/TlsLib/TlsLib.inf > CryptoPkg/Library/OpensslLib/OpensslLib.inf > + CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > > [Components.IA32, Components.X64] > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf >
I'd like to suggest wording / spelling improvements: - [Componnets] should be [Components] - While I'm not a native English speaker, I believe "missing" would be more precise than "lacking". To me, "lacking" implies that the library instances in question have shortcomings. However, that's not what we mean here -- those library instances are just fine, they are just missing from the DSC files. Hence my suggestion to say "missing" (in both the subject line and the commit message). Thank you Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42273): https://edk2.groups.io/g/devel/message/42273 Mute This Topic: https://groups.io/mt/32037312/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
