> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Thursday, June 13, 2019 4:20 PM
> To: Gao, Zhichao; devel@edk2.groups.io
> Cc: Bret Barkelew; Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Sean 
> Brogan;
> Michael Turner
> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Add lacking instances for
> build only
> 
> > -----Original Message-----
> > From: Gao, Zhichao
> > Sent: Wednesday, June 12, 2019 10:40 AM
> > To: devel@edk2.groups.io
> > Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, 
> > Liming;
> > Sean Brogan; Michael Turner
> > Subject: [PATCH] MdeModulePkg: Add lacking instances for build only
> 
> There are 224 INF files in MdeModulePkg, and now there are 224
> occurrences
> when searching '^  MdeModulePkg.+\.inf' in MdeModulePkg.dsc. The
> number
> matches.
> 
> Also, seems to me ARM & AARCH64 also build fine.
> 
> Then, with a similar suggestion at:
> https://edk2.groups.io/g/devel/topic/32037312#42319
> 
> handled:
> Reviewed-by: Hao A Wu <hao.a...@intel.com>

Pushed via commit 6764fb9cd8.

Best Regards,
Hao Wu

> 
> Best Regards,
> Hao Wu
> 
> 
> >
> > From: Bret Barkelew <bret.barke...@microsoft.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1857
> >
> > Add the lacking instances to the [Components] of dsc file
> > for build only.
> >
> > Cc: Jian J Wang <jian.j.w...@intel.com>
> > Cc: Hao Wu <hao.a...@intel.com>
> > Cc: Ray Ni <ray...@intel.com>
> > Cc: Star Zeng <star.z...@intel.com>
> > Cc: Liming Gao <liming....@intel.com>
> > Cc: Sean Brogan <sean.bro...@microsoft.com>
> > Cc: Michael Turner <michael.tur...@microsoft.com>
> > Cc: Bret Barkelew <bret.barke...@microsoft.com>
> > Signed-off-by: Zhichao Gao <zhichao....@intel.com>
> > ---
> >  MdeModulePkg/MdeModulePkg.dsc | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/MdeModulePkg/MdeModulePkg.dsc
> > b/MdeModulePkg/MdeModulePkg.dsc
> > index 995fd805e1..f32adc3839 100644
> > --- a/MdeModulePkg/MdeModulePkg.dsc
> > +++ b/MdeModulePkg/MdeModulePkg.dsc
> > @@ -204,6 +204,22 @@
> >    MdeModulePkg/Application/DumpDynPcd/DumpDynPcd.inf
> >    MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf
> >
> > +  MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
> > +  MdeModulePkg/Logo/Logo.inf
> > +  MdeModulePkg/Logo/LogoDxe.inf
> > +  MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> > +
> >
> MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance
> > ManagerUiLib.inf
> > +  MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
> > +  MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
> > +  MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf
> > +  MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf
> > +  MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
> > +  MdeModulePkg/Library/PciHostBridgeLibNull/PciHostBridgeLibNull.inf
> > +
> >
> MdeModulePkg/Library/PiSmmCoreSmmServicesTableLib/PiSmmCoreSmmS
> > ervicesTableLib.inf
> > +  MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
> > +  MdeModulePkg/Library/BaseHobLibNull/BaseHobLibNull.inf
> > +
> >
> MdeModulePkg/Library/BaseMemoryAllocationLibNull/BaseMemoryAllocati
> > onLibNull.inf
> > +
> >    MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
> >    MdeModulePkg/Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf
> >    MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
> > --
> > 2.21.0.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42469): https://edk2.groups.io/g/devel/message/42469
Mute This Topic: https://groups.io/mt/32037315/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to