Reviewed-by: Liming Gao <[email protected]> >-----Original Message----- >From: [email protected] [mailto:[email protected]] On Behalf Of >Laszlo Ersek >Sent: Wednesday, September 18, 2019 3:49 AM >To: edk2-devel-groups-io <[email protected]> >Cc: Gao, Liming <[email protected]>; Kinney, Michael D ><[email protected]> >Subject: [edk2-devel] [PATCH 17/35] MdePkg/DxeServicesLib: remove bogus >cast > >The HandleProtocol() boot service takes an EFI_HANDLE, not an >(EFI_HANDLE*). Remove the bogus cast in the >InternalImageHandleToFvHandle() function. > >This is a semantic cleanup; there is no change in behavior. > >Cc: Liming Gao <[email protected]> >Cc: Michael D Kinney <[email protected]> >Signed-off-by: Laszlo Ersek <[email protected]> >--- > >Notes: > lightly tested, most probably: it's practically impossible to build a > platform without consuming DxeServicesLib > > MdePkg/Library/DxeServicesLib/DxeServicesLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/MdePkg/Library/DxeServicesLib/DxeServicesLib.c >b/MdePkg/Library/DxeServicesLib/DxeServicesLib.c >index c416b2dd8c65..0735b2f80400 100644 >--- a/MdePkg/Library/DxeServicesLib/DxeServicesLib.c >+++ b/MdePkg/Library/DxeServicesLib/DxeServicesLib.c >@@ -49,7 +49,7 @@ InternalImageHandleToFvHandle ( > ASSERT (ImageHandle != NULL); > > Status = gBS->HandleProtocol ( >- (EFI_HANDLE *) ImageHandle, >+ ImageHandle, > &gEfiLoadedImageProtocolGuid, > (VOID **) &LoadedImage > ); >-- >2.19.1.3.g30247aa5d201 > > > >-=-=-=-=-=-= >Groups.io Links: You receive all messages sent to this group. > >View/Reply Online (#47404): https://edk2.groups.io/g/devel/message/47404 >Mute This Topic: https://groups.io/mt/34180218/1759384 >Group Owner: [email protected] >Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] >-=-=-=-=-=-=
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47453): https://edk2.groups.io/g/devel/message/47453 Mute This Topic: https://groups.io/mt/34180218/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
