Reviewed-by: Siyuan Fu <[email protected]> > -----Original Message----- > From: [email protected] <[email protected]> On Behalf Of Laszlo > Ersek > Sent: 2019年9月18日 3:49 > To: edk2-devel-groups-io <[email protected]> > Cc: Wu, Jiaxin <[email protected]>; Fu, Siyuan <[email protected]> > Subject: [edk2-devel] [PATCH 21/35] NetworkPkg/TcpDxe: fix SockFreeFoo() > parameter list > > The SockFreeFoo() callback function for NetbufFromExt() has to match the > NET_VECTOR_EXT_FREE prototype, which takes a (VOID*) as callback > argument > (Arg). EFI_EVENT has nothing to do with NET_VECTOR_EXT_FREE. Fix the > SockFreeFoo() parameter list. > > This change is a no-op in practice. > > Cc: Jiaxin Wu <[email protected]> > Cc: Siyuan Fu <[email protected]> > Signed-off-by: Laszlo Ersek <[email protected]> > --- > > Notes: > build-tested only > > NetworkPkg/TcpDxe/SockImpl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/NetworkPkg/TcpDxe/SockImpl.c > b/NetworkPkg/TcpDxe/SockImpl.c > index f5e01771e2a8..fb28e2ed40d3 100644 > --- a/NetworkPkg/TcpDxe/SockImpl.c > +++ b/NetworkPkg/TcpDxe/SockImpl.c > @@ -67,13 +67,13 @@ SockBufNext ( > /** > User provided callback function for NetbufFromExt. > > - @param[in] Event The Event this notify function registered to, ignored. > + @param[in] Arg The Arg parameter forwarded by NetbufFromExt(). > Ignored. > > **/ > VOID > EFIAPI > SockFreeFoo ( > - IN EFI_EVENT Event > + IN VOID *Arg > ) > { > return; > -- > 2.19.1.3.g30247aa5d201 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#47408): https://edk2.groups.io/g/devel/message/47408 > Mute This Topic: https://groups.io/mt/34180222/1712935 > Group Owner: [email protected] > Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] > -=-=-=-=-=-=
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48154): https://edk2.groups.io/g/devel/message/48154 Mute This Topic: https://groups.io/mt/34180222/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
