Good catch! Reviewed by: Jiewen Yao <[email protected]>
> -----Original Message----- > From: Laszlo Ersek <[email protected]> > Sent: Thursday, October 3, 2019 7:07 PM > To: Zhang, Chao B <[email protected]>; Wang, Jian J > <[email protected]>; Yao, Jiewen <[email protected]> > Cc: edk2-devel-groups-io <[email protected]> > Subject: Re: [edk2-devel] [PATCH 27/35] SecurityPkg: stop abusing EFI_EVENT > for protocol notify registration > > Pinging SecurityPkg maintainers again, for reviewing this patch. > > Thanks > Laszlo > > On 09/26/19 14:46, Laszlo Ersek wrote: > > Chao, Jian, Jiewen, > > > > can you please review this patch? > > > > Thanks, > > Laszlo > > > > > > On 09/17/19 21:49, Laszlo Ersek wrote: > >> EfiCreateProtocolNotifyEvent() takes a (VOID**) for "Registration", > >> similarly to gBS->RegisterProtocolNotify(). We should pass the address of > >> an actual pointer-to-VOID, and not the address of an EFI_EVENT. EFI_EVENT > >> just happens to be specified as (VOID*), and has nothing to do with the > >> registration. > >> > >> This change is a no-op in practice; it's a semantic improvement. > >> > >> Cc: Chao Zhang <[email protected]> > >> Cc: Jian Wang <[email protected]> > >> Cc: Jiewen Yao <[email protected]> > >> Signed-off-by: Laszlo Ersek <[email protected]> > >> --- > >> > >> Notes: > >> build-tested only > >> > >> SecurityPkg/HddPassword/HddPasswordDxe.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/SecurityPkg/HddPassword/HddPasswordDxe.c > b/SecurityPkg/HddPassword/HddPasswordDxe.c > >> index b0d795b6597f..051e64091d7f 100644 > >> --- a/SecurityPkg/HddPassword/HddPasswordDxe.c > >> +++ b/SecurityPkg/HddPassword/HddPasswordDxe.c > >> @@ -2770,7 +2770,7 @@ HddPasswordDxeInit ( > >> { > >> EFI_STATUS Status; > >> HDD_PASSWORD_DXE_PRIVATE_DATA *Private; > >> - EFI_EVENT Registration; > >> + VOID *Registration; > >> EFI_EVENT EndOfDxeEvent; > >> EDKII_VARIABLE_LOCK_PROTOCOL *VariableLock; > >> > >> > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48464): https://edk2.groups.io/g/devel/message/48464 Mute This Topic: https://groups.io/mt/34180229/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
