Hi Patrick, I'm not familiar with UefiPayloadPkg. However, since we may want to enable the trusted console as earlier as possible, you may still need to keep the PlatformConsoleInit() call at the beginning of PlatformBootManagerBeforeConsole() to support the platform that has trusted/on-board Consoles.
Regards, Sunny Wang -----Original Message----- From: [email protected] <[email protected]> On Behalf Of Patrick Rudolph Sent: Tuesday, February 2, 2021 4:34 PM To: [email protected] Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected] Subject: [edk2-devel] [PATCH] UefiPayloadPkg/PlatformBootManager: Connect console after EndOfDxe Currently the console is connected before EndOfDxe causing OptionsROMs to be loaded, but their drivers aren't used and thus no GOP is installed. To make use of 3rdparty OptionROMs connect the console after EndOfDxe. Tested on Intel CFL board using Nvidia Quadro GPU. Signed-off-by: Patrick Rudolph <[email protected]> --- UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c index c5c6af0abc..7fa3a048b7 100644 --- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c +++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager. +++ c @@ -157,8 +157,6 @@ PlatformBootManagerBeforeConsole ( EFI_INPUT_KEY Down; EFI_BOOT_MANAGER_LOAD_OPTION BootOption; - PlatformConsoleInit (); - // // Register ENTER as CONTINUE key // @@ -192,6 +190,8 @@ PlatformBootManagerBeforeConsole ( // Dispatch deferred images after EndOfDxe event and ReadyToLock installation. // EfiBootManagerDispatchDeferredImages (); + + PlatformConsoleInit (); } /** -- 2.26.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71103): https://edk2.groups.io/g/devel/message/71103 Mute This Topic: https://groups.io/mt/80310284/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
