Trusted console is required for TCG Physical Presence and only trusted console could be connected before EndOfDxe. Since TCG Physical Presence is not enabled yet in the UefiPayloadPkg, I think it is ok to have this change.
Reviewed-by: Guo Dong <[email protected]> > -----Original Message----- > From: Patrick Rudolph <[email protected]> > Sent: Wednesday, February 3, 2021 3:26 AM > To: Wang, Sunny (HPS SW) <[email protected]> > Cc: [email protected]; Park, Aiden <[email protected]>; You, Benjamin > <[email protected]>; [email protected]; Ma, > Maurice <[email protected]>; Dong, Guo <[email protected]> > Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/PlatformBootManager: > Connect console after EndOfDxe > > Hi Sunny, > none of the other packages are doing this before EndOfDxe. And there's > no point in having trusted console as earlier as possible, as nothing > is displayed in PlatformBootManagerBeforeConsole(). > Please explain your use case. I don't see one here. > > Kind Regards, > Patrick Rudolph > > On Wed, Feb 3, 2021 at 10:32 AM Wang, Sunny (HPS SW) > <[email protected]> wrote: > > > > Hi Patrick, > > > > I'm not familiar with UefiPayloadPkg. However, since we may want to enable > the trusted console as earlier as possible, you may still need to keep the > PlatformConsoleInit() call at the beginning of > PlatformBootManagerBeforeConsole() to support the platform that has > trusted/on-board Consoles. > > > > Regards, > > Sunny Wang > > > > -----Original Message----- > > From: [email protected] <[email protected]> On Behalf Of Patrick > Rudolph > > Sent: Tuesday, February 2, 2021 4:34 PM > > To: [email protected] > > Cc: [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected] > > Subject: [edk2-devel] [PATCH] UefiPayloadPkg/PlatformBootManager: > Connect console after EndOfDxe > > > > Currently the console is connected before EndOfDxe causing OptionsROMs to > be loaded, but their drivers aren't used and thus no GOP is installed. > > > > To make use of 3rdparty OptionROMs connect the console after EndOfDxe. > > > > Tested on Intel CFL board using Nvidia Quadro GPU. > > > > Signed-off-by: Patrick Rudolph <[email protected]> > > --- > > UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c | > 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git > a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > > index c5c6af0abc..7fa3a048b7 100644 > > --- > a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > > +++ > b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager. > > +++ c > > @@ -157,8 +157,6 @@ PlatformBootManagerBeforeConsole ( > > EFI_INPUT_KEY Down; > > EFI_BOOT_MANAGER_LOAD_OPTION BootOption; > > > > - PlatformConsoleInit (); > > - > > // > > // Register ENTER as CONTINUE key > > // > > @@ -192,6 +190,8 @@ PlatformBootManagerBeforeConsole ( > > // Dispatch deferred images after EndOfDxe event and ReadyToLock > installation. > > // > > EfiBootManagerDispatchDeferredImages (); > > + > > + PlatformConsoleInit (); > > } > > > > /** > > -- > > 2.26.2 > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71379): https://edk2.groups.io/g/devel/message/71379 Mute This Topic: https://groups.io/mt/80310284/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
