On 07/10/2021 16:06, Leif Lindholm wrote:
On Wed, Oct 06, 2021 at 19:55:53 +0700, Nhi Pham wrote:
Would it be possible for PHYLib to link in ArmArchTimerLib directly
and wrap this there instead? Something about this integration just
feels kind of backwards to me.
Thanks Leif. That's great idea.
I will wrap it and re-send the patchset for PHYLib in the edk2-non-osi
repository as well.
Thanks!
Actually, if you do that, can you have a look at the coding style of
some the enums in
Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h ?
They have enumerations in UPPER_CASE_WITH_UNDERSCORES instead of
CamelCase.
Yes, sure. I will fix it.
Best regards,
Nhi
I noticed these after giving my r-b, so didn't bother bringing it up,
but if you're refreshing the patch anyway...
/
Leif
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81566): https://edk2.groups.io/g/devel/message/81566
Mute This Topic: https://groups.io/mt/85631150/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
