Hi, Something I've just noticed: edk2-libc also ships its own intrinsics ( https://github.com/tianocore/edk2-libc/blob/master/StdLib/LibC/CRT/Gcc.c)
I know edk2-libc is not part of the core edk2 repo but I think we should keep this in mind when this patch set gets merged. On Fri, Mar 18, 2022 at 1:27 AM gaoliming <gaolim...@byosoft.com.cn> wrote: > Gerd: > I suggest to submit the different BZs for those tasks. This patch set is > the first stage. Future enhancement can be added later. > > If no more comment for the first stage, this patch set can be merged > first. > > Thanks > Liming > > -----邮件原件----- > > 发件人: Gerd Hoffmann <kra...@redhat.com> > > 发送时间: 2022年3月16日 17:46 > > 收件人: devel@edk2.groups.io; michael.d.kin...@intel.com > > 抄送: Sean Brogan <sean.bro...@microsoft.com>; Lu, Xiaoyu1 > > <xiaoyu1...@intel.com>; Feng, Bob C <bob.c.f...@intel.com>; Rebecca Cran > > <rebe...@bsdio.com>; James Bottomley <j...@linux.ibm.com>; Sami > > Mujawar <sami.muja...@arm.com>; Justen, Jordan L > > <jordan.l.jus...@intel.com>; Aktas, Erdem <erdemak...@google.com>; Yao, > > Jiewen <jiewen....@intel.com>; Supreeth Venkatesh > > <supreeth.venkat...@arm.com>; Boeuf, Sebastien > > <sebastien.bo...@intel.com>; Gao, Zhichao <zhichao....@intel.com>; Liu, > > Zhiguang <zhiguang....@intel.com>; Maciej Rabeda > > <maciej.rab...@linux.intel.com>; Ma, Maurice <maurice...@intel.com>; > > Andrew Fish <af...@apple.com>; Ard Biesheuvel > > <ardb+tianoc...@kernel.org>; Tom Lendacky <thomas.lenda...@amd.com>; > > Peter Grehan <gre...@freebsd.org>; Jiang, Guomin > > <guomin.ji...@intel.com>; Bret Barkelew <bret.barke...@microsoft.com>; > > Chen, Christine <yuwei.c...@intel.com>; You, Benjamin > > <benjamin....@intel.com>; Schaefer, Daniel <daniel.schae...@hpe.com>; > > Gao, Liming <gaolim...@byosoft.com.cn>; Xu, Wei6 <wei6...@intel.com>; > > Wang, Jian J <jian.j.w...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com>; > Fu, > > Siyuan <siyuan...@intel.com>; Dong, Guo <guo.d...@intel.com>; > > kilian_ke...@hotmail.com; Chang, Abner <abner.ch...@hpe.com>; Oliver > > Steffen <ostef...@redhat.com>; Leif Lindholm <quic_llind...@quicinc.com > >; > > Brijesh Singh <brijesh.si...@amd.com>; Xu, Min M <min.m...@intel.com>; > > Ni, Ray <ray...@intel.com>; Alexei Fedorov <alexei.fedo...@arm.com>; > > Julien Grall <jul...@xen.org>; Wang, Nickle <nickle.w...@hpe.com>; Pawel > > Polawski <ppola...@redhat.com>; Anthony Perard > > <anthony.per...@citrix.com> > > 主题: Re: [edk2-devel] [PATCH 0/3] [RFC] consolidate compiler intrinsics > > > > On Tue, Mar 15, 2022 at 03:27:58PM +0000, Michael D Kinney wrote: > > > Hi Gerd, > > > > > > Thanks for working on this. I raised this topic in the new TianoCore > build > > and CI > > > meeting yesterday because the intrinsic libs are closely tied to the > > toolchains > > > supported by TianoCore. > > > > > > I agree with the concept of moving the compiler intrinsics to a library > in the > > MdePkg. > > > > > > + Sean Brogan > > > > > > Sean mentioned that he has some addition work on intrinsic libs for > Visual > > Studio > > > toolchains. It would be good to see if this set of changes is aligned > with > > those > > > efforts. > > > > Having a single place where all compiler intrinsics are located should > > simplify this kind of changes. > > > > > I see a few items that might be good to clean up at some point > > > * fltused should go into its own file. Not related to the strcmp() API > > > * I see size_t defined in multiple places using different mappings. > Would > > be good to > > > define that in a single location. > > > > Yes, sure. Both are valid points. > > > > I see this series as first step, consolidating the existing code in a > > singe place with (almost) no actual code changes. There surely will be > > incremental improvements and cleanups later on. I will need a few more > > intrinsic functions when moving edk2 to openssl 3.0 for example. > > > > take care, > > Gerd > > > > > > > > > -- Pedro Falcato -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87722): https://edk2.groups.io/g/devel/message/87722 Mute This Topic: https://groups.io/mt/89859980/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
