> Is the issue that you are trying to solve supporting larger serial console > modes or just wanting to use the largest possible text mode at a given > graphics resolution?
I spotted this issue when I wanted to use the largest possible text mode in UEFI shell at high graphics resolutions. Is it not enough reason for this commit? > The other way to get full screen text on the graphical console is to disable > the serial console in the Boot Maintenance Manager. Can you please elaborate this? I've tried to disable UART in "Boot Maintenance Manager -> Console Options" like this: ``` Console Input Device Select: PciRoot(0x0)/Pci(0x1,0x0)/Acpi(PNP0303,0x0) [X] PciRoot(0x0)/Pci(0x1,0x0)/Serial(0x0)/Uart(115200,8,N,1) [ ] Console Output Device Select: PciRoot(0x0)/Pci(0x2,0x0)/AcpiAdr(0x80010100) [X] PciRoot(0x0)/Pci(0x1,0x0)/Serial(0x0)/Uart(115200,8,N,1) [ ] Console Standard Error Device Select: PciRoot(0x0)/Pci(0x2,0x0)/AcpiAdr(0x80010100) [X] PciRoot(0x0)/Pci(0x1,0x0)/Serial(0x0)/Uart(115200,8,N,1) [ ] ``` But after reset, the console is 80x25 and all UART options are checked again. Also there is a menu "Boot Maintenance Manager -> Console Options -> Console Output Mode Select" that has "Set Console Output Mode", and it is always "80x25" without any options for me. Best regards, Konstantin Aladyshev On Wed, Sep 21, 2022 at 7:28 PM Kinney, Michael D <michael.d.kin...@intel.com> wrote: > > The other way to get full screen text on graphical console is to disable the > serial console > in the Boot Maintenance Manager. > > If the serial console is disabled then ConSplitterDxe will only see the text > modes supported > by GraphicsConsoleDxe which will include these higher text modes. > > Is the issue that you are trying to solve supporting larger serial console > modes or just > wanting to use the largest possible text mode at a given graphics resolution? > > Mike > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Konstantin > > Aladyshev > > Sent: Wednesday, September 21, 2022 1:24 AM > > To: Kinney, Michael D <michael.d.kin...@intel.com> > > Cc: devel@edk2.groups.io; Gao, Liming <gaolim...@byosoft.com.cn>; Wang, > > Jian J <jian.j.w...@intel.com>; Ni, Ray > > <ray...@intel.com> > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes > > > > I have tested it in the following way: > > - launch OVMF in Linux and connect with vnc > > - change resolution via the form browser (Device Manager -> OVMF > > Platform Configuration) from the default 640x480 to the 1920x1080 > > - "reset" > > - after the reset the system will boot to the 1920x1080 resolution and > > text mode 80x25 > > - check "mode" command output > > > > Before the commit this command displays only these modes: > > ``` > > Shell> mode > > Available modes for console output device. > > Col 80 Row 25 * > > Col 80 Row 50 > > Col 100 Row 31 > > ``` > > But with this commit the high resolution modes are present in the output: > > ``` > > Shell> mode > > Available modes for console output device. > > Col 80 Row 25 * > > Col 80 Row 50 > > Col 100 Row 31 > > Col 128 Row 40 > > Col 160 Row 42 > > Col 240 Row 56 > > ``` > > And in my case setting the appropriate "mode 240 56" at runtime works just > > fine: > > ``` > > Shell> mode 240 56 > > ``` > > After that the text output starts using the full screen. > > > > Best regards, > > Konstantin Aladyshev > > > > On Wed, Sep 21, 2022 at 4:46 AM Kinney, Michael D > > <michael.d.kin...@intel.com> wrote: > > > > > > Tera Term works. > > > > > > Mike > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > > > > gaoliming via groups.io > > > > Sent: Tuesday, September 20, 2022 6:26 PM > > > > To: Kinney, Michael D <michael.d.kin...@intel.com>; > > > > devel@edk2.groups.io; aladyshe...@gmail.com > > > > Cc: Wang, Jian J <jian.j.w...@intel.com>; Ni, Ray <ray...@intel.com> > > > > Subject: 回复: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes > > > > > > > > Konstantin: > > > > Do you try the terminal software (such as Putty) to display the text > > > > mode 160, 42 or 240, 56? > > > > I try Putty in my desktop. It can't display 240 * 56 in one screen. > > > > > > > > Thanks > > > > Liming > > > > > -----邮件原件----- > > > > > 发件人: Kinney, Michael D <michael.d.kin...@intel.com> > > > > > 发送时间: 2022年9月20日 5:02 > > > > > 收件人: devel@edk2.groups.io; aladyshe...@gmail.com; Kinney, Michael D > > > > > <michael.d.kin...@intel.com> > > > > > 抄送: Wang, Jian J <jian.j.w...@intel.com>; Gao, Liming > > > > > <gaolim...@byosoft.com.cn>; Ni, Ray <ray...@intel.com> > > > > > 主题: RE: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes > > > > > > > > > > This looks like a reasonable update to support platforms that have > > > > > both > > > > > graphical consoles and serial consoles. > > > > > > > > > > Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com> > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > > > > > Konstantin Aladyshev > > > > > > Sent: Monday, September 19, 2022 1:57 AM > > > > > > To: devel@edk2.groups.io > > > > > > Cc: Wang, Jian J <jian.j.w...@intel.com>; Gao, Liming > > > > > <gaolim...@byosoft.com.cn>; Ni, Ray <ray...@intel.com>; Konstantin > > > > > > Aladyshev <aladyshe...@gmail.com> > > > > > > Subject: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes > > > > > > > > > > > > The commit b807174fecacf4c9f8400cab4d6fb3f580284021 > > > > > > ("MdeModulePkg/GraphicsConsoleDxe: add modes") has added modes for > > > > > the > > > > > > high display resolutions. Support these modes in the TerminalDxe as > > > > > > well, so it would be possible to select the text mode that would > > > > > > take > > > > > > all the available screen space. > > > > > > > > > > > > Signed-off-by: Konstantin Aladyshev <aladyshe...@gmail.com> > > > > > > --- > > > > > > MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c | 3 +++ > > > > > > 1 file changed, 3 insertions(+) > > > > > > > > > > > > diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c > > > > > b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c > > > > > > index e2d779c783..6b7b970516 100644 > > > > > > --- a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c > > > > > > +++ b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c > > > > > > @@ -115,6 +115,9 @@ TERMINAL_CONSOLE_MODE_DATA > > > > > mTerminalConsoleModeData[] = { > > > > > > { 80, 25 }, > > > > > > > > > > > > { 80, 50 }, > > > > > > > > > > > > { 100, 31 }, > > > > > > > > > > > > + { 128, 40 }, > > > > > > > > > > > > + { 160, 42 }, > > > > > > > > > > > > + { 240, 56 }, > > > > > > > > > > > > // > > > > > > > > > > > > // New modes can be added here. > > > > > > > > > > > > // > > > > > > > > > > > > -- > > > > > > 2.25.1 > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-= > > > > > > Groups.io Links: You receive all messages sent to this group. > > > > > > View/Reply Online (#93935): > > > > > https://edk2.groups.io/g/devel/message/93935 > > > > > > Mute This Topic: https://groups.io/mt/93777396/1643496 > > > > > > Group Owner: devel+ow...@edk2.groups.io > > > > > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > > > > [michael.d.kin...@intel.com] > > > > > > -=-=-=-=-=-= > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94114): https://edk2.groups.io/g/devel/message/94114 Mute This Topic: https://groups.io/mt/93818606/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-