(apologies, still catching up from being away last week) +Hao, Ray as MdeModulePkg/Bus maintainers.
On Wed, Apr 12, 2023 at 04:25:35 +0000, Chang, Abner wrote: > [AMD Official Use Only - General] > > Hi Richard and Pedro, > Understand that is the standard USB communication class device, that > is why I think put it under MdeModulePkg/Bus/Usb/UsbNetwork makes > more sense because it is similar to the USB mass storage or HID > classes. Agreed 100%. / Leif > USB RNDIS driver and EDKII USB Ethernet protocol are on top of USB > devices that akin to BLOCK IO protocol to USB MSD, which I think > those two can be located under MdeModulePkg/Bus/Usb/UsbNetwork as > well because those are only used by USB CDC devices. > > That is no problem to add those fixed PCDs and other definitions > such as protocol definitions in MdeModulePkg.dec if UsbNetwork is > part of MdeModulePkg. > Thanks > Abner > > > -----Original Message----- > > From: Richard Ho (何明忠) <richar...@ami.com> > > Sent: Wednesday, April 12, 2023 10:27 AM > > To: Pedro Falcato <pedro.falc...@gmail.com>; devel@edk2.groups.io; > > rebe...@bsdio.com; Chang, Abner <abner.ch...@amd.com> > > Cc: Andrew Fish <af...@apple.com>; Leif Lindholm > > <quic_llind...@quicinc.com>; Michael D Kinney > > <michael.d.kin...@intel.com>; Michael Kubacki > > <mikub...@linux.microsoft.com>; Zhiguang Liu <zhiguang....@intel.com>; > > Liming Gao <gaolim...@byosoft.com.cn>; Tinh Nguyen > > <tinhngu...@os.amperecomputing.com>; Tony Lo (羅金松) > > <ton...@ami.com>; Marvin Häuser <mhaeu...@posteo.de> > > Subject: RE: [EXTERNAL] Re: [edk2-devel] [PATCH v7 1/3] > > UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > Hi Pedro/Abner, > > > > UsbNetworkPkg provide the RNDIS/ECM/NCM device support that are > > implement form USB specification(we have other USB network device's > > driver to upstream). > > It is not specific USB device. The driver could work on any platform. So, we > > create UsbNetworkPkg same as NetworkPkg in edk2 repo. > > > > Currently, we have some Fixed PCDs in UsbNetworkPkg.dec. Can add it to > > MdeModulePkg.dec? > > Which one is better for upstream from below rules? > > > > #1: edk2-platforms/Features/UsbNetworkPkg > > #2: edk2/MdeModulePkg/Bus/Usb/UsbNetwork > > #3: edk2/UsbNetworkPkg > > > > Thanks, > > Richard > > > > -----Original Message----- > > From: Pedro Falcato <pedro.falc...@gmail.com> > > Sent: 2023年4月11日 8:39 PM > > To: devel@edk2.groups.io; rebe...@bsdio.com > > Cc: Richard Ho (何明忠) <richar...@ami.com>; Andrew Fish > > <af...@apple.com>; Leif Lindholm <quic_llind...@quicinc.com>; Michael D > > Kinney <michael.d.kin...@intel.com>; Michael Kubacki > > <mikub...@linux.microsoft.com>; Zhiguang Liu <zhiguang....@intel.com>; > > Liming Gao <gaolim...@byosoft.com.cn>; Tinh Nguyen > > <tinhngu...@os.amperecomputing.com>; Tony Lo (羅金松) > > <ton...@ami.com>; Marvin Häuser <mhaeu...@posteo.de> > > Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v7 1/3] > > UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support > > > > > > **CAUTION: The e-mail below is from an external source. Please exercise > > caution before opening attachments, clicking links, or following guidance.** > > > > On Tue, Apr 11, 2023 at 1:31 PM Rebecca Cran <rebe...@bsdio.com> wrote: > > > Given this is adding a new top-level package, I'd like to see a > > > review/feedback from the TianoCore Stewards. > > > > I would personally love to understand why this is being pushed as a top > > level > > package in edk2 when "supposedly" edk2-platforms/Features is the more > > correct approach here (as discussed with Sean, Nate a few months back). > > > > Or is that hellscape only reserved for me? :v > > > > -- > > Pedro > > -The information contained in this message may be confidential and > > proprietary to American Megatrends (AMI). This communication is intended > > to be read only by the individual or entity to whom it is addressed or by > > their > > designee. If the reader of this message is not the intended recipient, you > > are > > on notice that any distribution of this message, in any form, is strictly > > prohibited. Please promptly notify the sender by reply e-mail or by > > telephone at 770-246-8600, and then delete or destroy all copies of the > > transmission. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103172): https://edk2.groups.io/g/devel/message/103172 Mute This Topic: https://groups.io/mt/98122714/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-