Hi Rebecca, ECM and NCM will be enable when move the UsbNetworkPkg to MdeModulePkg\Bus\Usb\UsbNetwork.
About rate limiting. We have test it X86 system. It will be slow to PXE boot. Do you think this PCD should be enabled by default? Thanks, Richard -----Original Message----- From: Rebecca Cran <rebe...@bsdio.com> Sent: 2023年4月20日 12:34 AM To: Richard Ho (何明忠) <richar...@ami.com> Cc: Andrew Fish <af...@apple.com>; Leif Lindholm <quic_llind...@quicinc.com>; Michael D Kinney <michael.d.kin...@intel.com>; Michael Kubacki <mikub...@linux.microsoft.com>; Zhiguang Liu <zhiguang....@intel.com>; Liming Gao <gaolim...@byosoft.com.cn>; Tinh Nguyen <tinhngu...@os.amperecomputing.com>; Tony Lo (羅金松) <ton...@ami.com>; devel@edk2.groups.io Subject: Re: [EXTERNAL] Re: [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support Hi Richard, I was wondering if you'd seen my questions about ECM and NCM, and rate limiting? -- Rebecca Cran On 4/11/23 6:31 AM, Rebecca Cran wrote: > Yes, you can add me as a reviewer. > > A couple more comments on the patches: why are ECM and NCM disabled by > default? > > I've tested on my Juno R2 system and it appears rate limiting is > required, so should it be enabled by default? > > > Given this is adding a new top-level package, I'd like to see a > review/feedback from the TianoCore Stewards. > > -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103268): https://edk2.groups.io/g/devel/message/103268 Mute This Topic: https://groups.io/mt/98122714/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
