Hi Pierre,

Thank you for this patch.

This change looks good to me.

Reviewed-by: Sami Mujawar <sami.muja...@arm.com>

Regards,

Sami Mujawar

On 09/05/2023 08:40 am, pierre.gond...@arm.com wrote:
From: Pierre Gondois <pierre.gond...@arm.com>

Remove ASSERTs to allow RngDxe probing the Null implementation
of the TrngLib.

Signed-off-by: Pierre Gondois <pierre.gond...@arm.com>
---
  MdePkg/Library/BaseArmTrngLibNull/BaseArmTrngLibNull.c | 4 ----
  1 file changed, 4 deletions(-)

diff --git a/MdePkg/Library/BaseArmTrngLibNull/BaseArmTrngLibNull.c 
b/MdePkg/Library/BaseArmTrngLibNull/BaseArmTrngLibNull.c
index 316d78bf5e83..0ea9aafa59f1 100644
--- a/MdePkg/Library/BaseArmTrngLibNull/BaseArmTrngLibNull.c
+++ b/MdePkg/Library/BaseArmTrngLibNull/BaseArmTrngLibNull.c
@@ -41,7 +41,6 @@ GetArmTrngVersion (
    OUT UINT16  *MinorRevision
    )
  {
-  ASSERT (FALSE);
    return RETURN_UNSUPPORTED;
  }
@@ -67,7 +66,6 @@ GetArmTrngUuid (
    OUT GUID  *Guid
    )
  {
-  ASSERT (FALSE);
    return RETURN_UNSUPPORTED;
  }
@@ -83,7 +81,6 @@ GetArmTrngMaxSupportedEntropyBits (
    VOID
    )
  {
-  ASSERT (FALSE);
    return 0;
  }
@@ -116,6 +113,5 @@ GetArmTrngEntropy (
    OUT UINT8  *Buffer
    )
  {
-  ASSERT (FALSE);
    return RETURN_UNSUPPORTED;
  }


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106506): https://edk2.groups.io/g/devel/message/106506
Mute This Topic: https://groups.io/mt/98779038/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to