Hi Pierre,
Do we really need this removal of ASSERT? I tried to use the real
ArmTrngLib with this patch
and it seems to work fine with a TFA that does not support TRNG interfaces.
I think it would be valuable to keep the ASSERT to indicate there might
be an integration error?
Please let me know if I missed anything.
Regards,
Kun
On 5/9/2023 12:40 AM, PierreGondois wrote:
From: Pierre Gondois <pierre.gond...@arm.com>
Remove ASSERTs to allow RngDxe probing the Null implementation
of the TrngLib.
Signed-off-by: Pierre Gondois <pierre.gond...@arm.com>
---
MdePkg/Library/BaseArmTrngLibNull/BaseArmTrngLibNull.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/MdePkg/Library/BaseArmTrngLibNull/BaseArmTrngLibNull.c
b/MdePkg/Library/BaseArmTrngLibNull/BaseArmTrngLibNull.c
index 316d78bf5e83..0ea9aafa59f1 100644
--- a/MdePkg/Library/BaseArmTrngLibNull/BaseArmTrngLibNull.c
+++ b/MdePkg/Library/BaseArmTrngLibNull/BaseArmTrngLibNull.c
@@ -41,7 +41,6 @@ GetArmTrngVersion (
OUT UINT16 *MinorRevision
)
{
- ASSERT (FALSE);
return RETURN_UNSUPPORTED;
}
@@ -67,7 +66,6 @@ GetArmTrngUuid (
OUT GUID *Guid
)
{
- ASSERT (FALSE);
return RETURN_UNSUPPORTED;
}
@@ -83,7 +81,6 @@ GetArmTrngMaxSupportedEntropyBits (
VOID
)
{
- ASSERT (FALSE);
return 0;
}
@@ -116,6 +113,5 @@ GetArmTrngEntropy (
OUT UINT8 *Buffer
)
{
- ASSERT (FALSE);
return RETURN_UNSUPPORTED;
}
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106529): https://edk2.groups.io/g/devel/message/106529
Mute This Topic: https://groups.io/mt/98779038/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
