Joey: For MdePkg, MdeModulePkg, FmpDevicePkg, Reviewed-by: Liming Gao <[email protected]>
Thanks Liming 发件人: Joey Vagedes <[email protected]> 发送时间: 2023年8月2日 0:17 收件人: [email protected] 抄送: Alexei Fedorov <[email protected]>; Ard Biesheuvel <[email protected]>; Ashraf Ali S <[email protected]>; Chasel Chiu <[email protected]>; Chen Gang C <[email protected]>; Daniel Schaefer <[email protected]>; Duggapu Chinni B <[email protected]>; Eric Dong <[email protected]>; Gerd Hoffmann <[email protected]>; Guo Dong <[email protected]>; Guomin Jiang <[email protected]>; Hao A Wu <[email protected]>; Igor Kulchytskyy <[email protected]>; James Lu <[email protected]>; Jian J Wang <[email protected]>; Jiewen Yao <[email protected]>; Leif Lindholm <[email protected]>; Liming Gao <[email protected]>; Maciej Rabeda <[email protected]>; Michael D Kinney <[email protected]>; Michael Kubacki <[email protected]>; Nate DeSimone <[email protected]>; Nickle Wang <[email protected]>; Pierre Gondois <[email protected]>; Rahul Kumar <[email protected]>; Ray Han Lim Ng <[email protected]>; Ray Ni <[email protected]>; Sami Mujawar <[email protected]>; Sean Brogan <[email protected]>; Sean Rhodes <[email protected]>; Siyuan Fu <[email protected]>; Star Zeng <[email protected]>; Susovan Mohapatra <[email protected]>; Ted Kuo <[email protected]>; Wei6 Xu <[email protected]>; Xiaoyu Lu <[email protected]>; Yi Li <[email protected]>; Zhichao Gao <[email protected]>; Zhiguang Liu <[email protected]> 主题: Re: [PATCH v1 00/24] Update Edk2-pytools to latest versions Hello everyone, I'm still looking for reviews for this change. Please remember this has no effect on the package itself, rather it adds additional helps to ensure your package is tested when necessary. The particular situation this change now catches is when a library instance (INF) from outside your package changes and your package consumes that library instance. When this situation occurs, your package will also be built as a part of CI, ensuring other package changes don't break your package in a build breaking way. I still need reviews from the following packages: - UefiPayloadPkg - ArmPkg - UefiCpuPkg - ArmPlatformPkg - CryptoPkg - FatPkg - FmpDevicePkg - IntelFsp2Pkg - CryptoPkg - SourceLevelDebugPkg - SignedCapsulePkg - ShellPkg - SecurityPkg - PcAtChipsetPkg - NetworkPkg - MdePkg - MdeModulePkg - IntelFsp2WrapperPkg Thank you to those that have already reviewed! Thanks, Joey On Thu, Jul 6, 2023 at 8:22 AM Joey Vagedes <[email protected] <mailto:[email protected]> > wrote: Hello everyone, Just following up on this patch series; looking for reviews from each package owner. Just to reiterate, this patch series enables a new policy for detecting which packages should be built for any given PR / Patch on github. The policy is used when an INF is changed. It requires that any package consuming that inf (generally a library instance) be built and tested. I'm happy to help answer any questions! Thanks, Joey On Mon, Jun 26, 2023 at 2:34 PM Joey Vagedes <[email protected] <mailto:[email protected]> > wrote: Updates Edk2-pytools to the latest versions, which introduces a new Policy for detecting which packages must be built given a set of changes. This policy is used when a library class instance INF is changed. When this occurs, it will review the PrEval:DscPath provided in the CI YAML file and determine if the package uses the library instance or not. If it does, it will build and test the package. Due to these changes, each package must now include an entry in it's CI YAML file (PrEval:DscPath). If the package does not provide this entry, this policy will be skipped, which could lead to a library instance breaking packages outside of it's parent package. Cc: Abner Chang <[email protected] <mailto:[email protected]> > Cc: Alexei Fedorov <[email protected] <mailto:[email protected]> > Cc: Ard Biesheuvel <[email protected] <mailto:ardb%[email protected]> > Cc: Ashraf Ali S <[email protected] <mailto:[email protected]> > Cc: Chasel Chiu <[email protected] <mailto:[email protected]> > Cc: Chen Gang C <[email protected] <mailto:[email protected]> > Cc: Daniel Schaefer <[email protected] <mailto:[email protected]> > Cc: Duggapu Chinni B <[email protected] <mailto:[email protected]> > Cc: Eric Dong <[email protected] <mailto:[email protected]> > Cc: Gerd Hoffmann <[email protected] <mailto:[email protected]> > Cc: Guo Dong <[email protected] <mailto:[email protected]> > Cc: Guomin Jiang <[email protected] <mailto:[email protected]> > Cc: Hao A Wu <[email protected] <mailto:[email protected]> > Cc: Igor Kulchytskyy <[email protected] <mailto:[email protected]> > Cc: James Lu <[email protected] <mailto:[email protected]> > Cc: Jian J Wang <[email protected] <mailto:[email protected]> > Cc: Jiewen Yao <[email protected] <mailto:[email protected]> > Cc: Leif Lindholm <[email protected] <mailto:[email protected]> > Cc: Liming Gao <[email protected] <mailto:[email protected]> > Cc: Maciej Rabeda <[email protected] <mailto:[email protected]> > Cc: Michael D Kinney <[email protected] <mailto:[email protected]> > Cc: Michael Kubacki <[email protected] <mailto:[email protected]> > Cc: Nate DeSimone <[email protected] <mailto:[email protected]> > Cc: Nickle Wang <[email protected] <mailto:[email protected]> > Cc: Pierre Gondois <[email protected] <mailto:[email protected]> > Cc: Rahul Kumar <[email protected] <mailto:[email protected]> > Cc: Ray Han Lim Ng <[email protected] <mailto:[email protected]> > Cc: Ray Ni <[email protected] <mailto:[email protected]> > Cc: Sami Mujawar <[email protected] <mailto:[email protected]> > Cc: Sean Brogan <[email protected] <mailto:[email protected]> > Cc: Sean Rhodes <[email protected] <mailto:[email protected]> > Cc: Siyuan Fu <[email protected] <mailto:[email protected]> > Cc: Star Zeng <[email protected] <mailto:[email protected]> > Cc: Susovan Mohapatra <[email protected] <mailto:[email protected]> > Cc: Ted Kuo <[email protected] <mailto:[email protected]> > Cc: Wei6 Xu <[email protected] <mailto:[email protected]> > Cc: Xiaoyu Lu <[email protected] <mailto:[email protected]> > Cc: Yi Li <[email protected] <mailto:[email protected]> > Cc: Zhichao Gao <[email protected] <mailto:[email protected]> > Cc: Zhiguang Liu <[email protected] <mailto:[email protected]> > Joey Vagedes (24): Edk2: edk2-pytools: Update to latest versions UnitTestFrameworkPkg: CI: Add PrEval entry UefiPayloadPkg: CI: Add PrEval entry ArmPkg: CI: Add PrEval entry UefiCpuPkg: CI: Add PrEval entry ArmPlatformPkg: CI: Add PrEval entry CryptoPkg: CI: Add PrEval entry DynamicTablesPkg: CI: Add PrEval entry EmbeddedPkg: CI: Add PrEval entry FatPkg: CI: Add PrEval entry FmpDevicePkg: CI: Add PrEval entry IntelFsp2Pkg: CI: Add PrEval entry CryptoPkg: CI: Add PrEval entry SourceLevelDebugPkg: CI: Add PrEval entry SignedCapsulePkg: CI: Add PrEval entry ShellPkg: CI: Add PrEval entry SecurityPkg: CI: Add PrEval entry RedfishPkg: CI: Add PrEval entry PrmPkg: CI: Add PrEval entry PcAtChipsetPkg: CI: Add PrEval entry NetworkPkg: CI: Add PrEval entry MdePkg: CI: Add PrEval entry MdeModulePkg: CI: Add PrEval entry IntelFsp2WrapperPkg: CI: Add PrEval entry ArmPkg/ArmPkg.ci.yaml | 3 +++ ArmPlatformPkg/ArmPlatformPkg.ci.yaml | 3 +++ CryptoPkg/CryptoPkg.ci.yaml | 3 +++ DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 3 +++ EmbeddedPkg/EmbeddedPkg.ci.yaml | 3 +++ FatPkg/FatPkg.ci.yaml | 3 +++ FmpDevicePkg/FmpDevicePkg.ci.yaml | 3 +++ IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml | 3 +++ IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml | 3 +++ MdeModulePkg/MdeModulePkg.ci.yaml | 3 +++ MdePkg/MdePkg.ci.yaml | 3 +++ NetworkPkg/NetworkPkg.ci.yaml | 3 +++ PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 3 +++ PrmPkg/PrmPkg.ci.yaml | 3 +++ RedfishPkg/RedfishPkg.ci.yaml | 3 +++ SecurityPkg/SecurityPkg.ci.yaml | 3 +++ ShellPkg/ShellPkg.ci.yaml | 3 +++ SignedCapsulePkg/SignedCapsulePkg.ci.yaml | 3 +++ SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml | 3 +++ StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 3 +++ UefiCpuPkg/UefiCpuPkg.ci.yaml | 3 +++ UefiPayloadPkg/UefiPayloadPkg.ci.yaml | 3 +++ UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 3 +++ pip-requirements.txt | 4 ++-- 24 files changed, 71 insertions(+), 2 deletions(-) -- 2.41.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107440): https://edk2.groups.io/g/devel/message/107440 Mute This Topic: https://groups.io/mt/100498733/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
