Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn> > -----邮件原件----- > 发件人: Yeping Song <quic_yepi...@quicinc.com> > 发送时间: 2023年11月4日 0:38 > 收件人: devel@edk2.groups.io > 抄送: Yeping Song <quic_yepi...@quicinc.com>; Rebecca Cran > <rebe...@bsdio.com>; Liming Gao <gaolim...@byosoft.com.cn>; Bob Feng > <bob.c.f...@intel.com>; Yuwei Chen <yuwei.c...@intel.com>; Ard > Biesheuvel <ardb+tianoc...@kernel.org>; Leif Lindholm > <quic_llind...@quicinc.com>; Sami Mujawar <sami.muja...@arm.com> > 主题: [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-regs-only for > AArch64 CLANGDWARF > > Commit 0df6c8c157af9 ("BaseTools/tools_def AARCH64: > avoid SIMD registers in XIP code") > adds -mgeneral-regs-only to GCC_AARCH64_CC_XIPFLAGS, > in order to avoid a bug present in certain versions of GCC. > This was never a problem for clang. > That's given the history of what the problem is. > Then we can describe how we fix it: > Change *_CLANGDWARF_AARCH64_CC_XIPFLAGS to set the required > -mstrict-align > option instead of importing the whole GCC variable. > > Signed-off-by: Yeping Song <quic_yepi...@quicinc.com> > Cc: Rebecca Cran <rebe...@bsdio.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Bob Feng <bob.c.f...@intel.com> > Cc: Yuwei Chen <yuwei.c...@intel.com> > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > Cc: Leif Lindholm <quic_llind...@quicinc.com> > Cc: Sami Mujawar <sami.muja...@arm.com> > --- > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Conf/tools_def.template > b/BaseTools/Conf/tools_def.template > index 5bd5283655ea..c34ecfd557c5 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -2015,7 +2015,7 @@ DEFINE CLANGDWARF_AARCH64_DLINK_FLAGS > = DEF(CLANGDWARF_AARCH64_TARGET) DEF(GCC_ > *_CLANGDWARF_AARCH64_RC_FLAGS = > DEF(GCC_AARCH64_RC_FLAGS) DEF(GCC_AARCH64_RC_BTI_FLAGS) > *_CLANGDWARF_AARCH64_VFRPP_FLAGS = DEF(GCC_VFRPP_FLAGS) > DEF(CLANGDWARF_AARCH64_TARGET) $(PLATFORM_FLAGS) > *_CLANGDWARF_AARCH64_ASLPP_FLAGS = DEF(GCC_ASLPP_FLAGS) > DEF(CLANGDWARF_AARCH64_TARGET) > -*_CLANGDWARF_AARCH64_CC_XIPFLAGS = > DEF(GCC_AARCH64_CC_XIPFLAGS) > +*_CLANGDWARF_AARCH64_CC_XIPFLAGS = -mstrict-align > > DEBUG_CLANGDWARF_AARCH64_CC_FLAGS = > DEF(CLANGDWARF_AARCH64_CC_FLAGS) $(PLATFORM_FLAGS) -flto -O1 > DEBUG_CLANGDWARF_AARCH64_DLINK_FLAGS = > DEF(CLANGDWARF_AARCH64_DLINK_FLAGS) -flto -Wl,-O1 -fuse-ld=lld > -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64 > -Wl,-plugin-opt=-pass-through=-llto-aarch64 -Wl,--no-pie,--no-relax > -- > 2.25.1
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110690): https://edk2.groups.io/g/devel/message/110690 Mute This Topic: https://groups.io/mt/102412109/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-