Merged: https://github.com/tianocore/edk2/pull/5023 https://github.com/tianocore/edk2/commit/e077ccff6d0f2e8c3fc44b3e2ab71aff66927c3b
Mike > -----Original Message----- > From: Leif Lindholm <quic_llind...@quicinc.com> > Sent: Thursday, November 9, 2023 6:39 AM > To: devel@edk2.groups.io; Gao, Liming <gaolim...@byosoft.com.cn> > Cc: 'Yeping Song (QUIC)' <quic_yepi...@quicinc.com>; 'Rebecca Cran' > <rebe...@bsdio.com>; Feng, Bob C <bob.c.f...@intel.com>; Chen, > Christine <yuwei.c...@intel.com>; 'Ard Biesheuvel' > <ardb+tianoc...@kernel.org>; 'Sami Mujawar' <sami.muja...@arm.com>; > Kinney, Michael D <michael.d.kin...@intel.com> > Subject: Re: 回复: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop - > mgeneral-regs-only for AArch64 CLANGDWARF > > Thanks! > > https://github.com/tianocore/edk2/pull/5023 raised. > > / > Leif > > On Thu, Nov 09, 2023 at 21:42:38 +0800, gaoliming via groups.io wrote: > > Leif: > > Sure. This patch can be merged for this stable tag. > > > > Thanks > > Liming > > > -----邮件原件----- > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Leif > Lindholm > > > 发送时间: 2023年11月7日 21:13 > > > 收件人: Yeping Song (QUIC) <quic_yepi...@quicinc.com>; > > > devel@edk2.groups.io; Liming Gao <gaolim...@byosoft.com.cn> > > > 抄送: Rebecca Cran <rebe...@bsdio.com>; Bob Feng > > > <bob.c.f...@intel.com>; Yuwei Chen <yuwei.c...@intel.com>; Ard > > > Biesheuvel <ardb+tianoc...@kernel.org>; Sami Mujawar > > > <sami.muja...@arm.com>; Kinney, Michael D > <michael.d.kin...@intel.com> > > > 主题: Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop > > > -mgeneral-regs-only for AArch64 CLANGDWARF > > > > > > Liming, > > > > > > You reviewed this patch before the stable tag. Am I OK to stage a > github > > > PR for this change? > > > > > > Reviewed-by: Leif Lindholm <quic_llind...@quicinc.com> > > > > > > Regards, > > > > > > Leif > > > > > > On 2023-11-07 13:11, Yeping Song (QUIC) wrote: > > > > Hi all, > > > > I would like for this to be include in stable tag. Please help > to review and > > > merge this patch into stable release. > > > > Thanks > > > > Yepings > > > > > > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > Yeping > > > Song > > > > Sent: Saturday, November 4, 2023 12:38 AM > > > > To: devel@edk2.groups.io > > > > Cc: Yeping Song (QUIC) <quic_yepi...@quicinc.com>; Rebecca Cran > > > <rebe...@bsdio.com>; Liming Gao <gaolim...@byosoft.com.cn>; Bob > Feng > > > <bob.c.f...@intel.com>; Yuwei Chen <yuwei.c...@intel.com>; Ard > > > Biesheuvel <ardb+tianoc...@kernel.org>; Leif Lindholm (QUIC) > > > <quic_llind...@quicinc.com>; Sami Mujawar <sami.muja...@arm.com> > > > > Subject: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop > > > -mgeneral-regs-only for AArch64 CLANGDWARF > > > > > > > > WARNING: This email originated from outside of Qualcomm. Please > be wary > > > of any links or attachments, and do not enable macros. > > > > > > > > Commit 0df6c8c157af9 ("BaseTools/tools_def AARCH64: > > > > avoid SIMD registers in XIP code") > > > > adds -mgeneral-regs-only to GCC_AARCH64_CC_XIPFLAGS, in order to > avoid > > > a bug present in certain versions of GCC. > > > > This was never a problem for clang. > > > > That's given the history of what the problem is. > > > > Then we can describe how we fix it: > > > > Change *_CLANGDWARF_AARCH64_CC_XIPFLAGS to set the required > > > -mstrict-align option instead of importing the whole GCC variable. > > > > > > > > Signed-off-by: Yeping Song <quic_yepi...@quicinc.com> > > > > Cc: Rebecca Cran <rebe...@bsdio.com> > > > > Cc: Liming Gao <gaolim...@byosoft.com.cn> > > > > Cc: Bob Feng <bob.c.f...@intel.com> > > > > Cc: Yuwei Chen <yuwei.c...@intel.com> > > > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > > > > Cc: Leif Lindholm <quic_llind...@quicinc.com> > > > > Cc: Sami Mujawar <sami.muja...@arm.com> > > > > --- > > > > BaseTools/Conf/tools_def.template | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/BaseTools/Conf/tools_def.template > > > b/BaseTools/Conf/tools_def.template > > > > index 5bd5283655ea..c34ecfd557c5 100755 > > > > --- a/BaseTools/Conf/tools_def.template > > > > +++ b/BaseTools/Conf/tools_def.template > > > > @@ -2015,7 +2015,7 @@ DEFINE CLANGDWARF_AARCH64_DLINK_FLAGS > > > = DEF(CLANGDWARF_AARCH64_TARGET) DEF(GCC_ > > > > *_CLANGDWARF_AARCH64_RC_FLAGS = > > > DEF(GCC_AARCH64_RC_FLAGS) DEF(GCC_AARCH64_RC_BTI_FLAGS) > > > > *_CLANGDWARF_AARCH64_VFRPP_FLAGS = > > > DEF(GCC_VFRPP_FLAGS) DEF(CLANGDWARF_AARCH64_TARGET) > > > $(PLATFORM_FLAGS) > > > > *_CLANGDWARF_AARCH64_ASLPP_FLAGS = > > > DEF(GCC_ASLPP_FLAGS) DEF(CLANGDWARF_AARCH64_TARGET) > > > > -*_CLANGDWARF_AARCH64_CC_XIPFLAGS = > > > DEF(GCC_AARCH64_CC_XIPFLAGS) > > > > +*_CLANGDWARF_AARCH64_CC_XIPFLAGS = -mstrict-align > > > > > > > > DEBUG_CLANGDWARF_AARCH64_CC_FLAGS = > > > DEF(CLANGDWARF_AARCH64_CC_FLAGS) $(PLATFORM_FLAGS) -flto -O1 > > > > DEBUG_CLANGDWARF_AARCH64_DLINK_FLAGS = > > > DEF(CLANGDWARF_AARCH64_DLINK_FLAGS) -flto -Wl,-O1 -fuse-ld=lld > > > -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64 > > > -Wl,-plugin-opt=-pass-through=-llto-aarch64 -Wl,--no-pie,--no- > relax > > > > -- > > > > 2.25.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110996): https://edk2.groups.io/g/devel/message/110996 Mute This Topic: https://groups.io/mt/102485456/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
