On 11/6/23 04:30, Chao Li wrote: > This library is provides boot mananger interfaces, and it is referenced > from ArmVirtPkg. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Gerd Hoffmann <kra...@redhat.com> > Signed-off-by: Chao Li <lic...@loongson.cn> > Co-authored-by: Xianglai Li <lixiang...@loongson.cn> > Co-authored-by: Bibo Mao <maob...@loongson.cn> > --- > .../PlatformBootManagerLib/PlatformBm.c | 829 ++++++++++++++++++ > .../PlatformBootManagerLib/PlatformBm.h | 112 +++ > .../PlatformBootManagerLib.inf | 73 ++ > .../PlatformBootManagerLib/QemuKernel.c | 81 ++ > 4 files changed, 1095 insertions(+) > create mode 100644 > OvmfPkg/LoongArchVirt/Library/PlatformBootManagerLib/PlatformBm.c > create mode 100644 > OvmfPkg/LoongArchVirt/Library/PlatformBootManagerLib/PlatformBm.h > create mode 100644 > OvmfPkg/LoongArchVirt/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > create mode 100644 > OvmfPkg/LoongArchVirt/Library/PlatformBootManagerLib/QemuKernel.c
I wish it were "referenced"; it's not referenced but *copied*. Why is the library in ArmVirtPkg not good enough? What are the differences? Etc. I'm not even asking about the specifics here, but trying to show you how you should please *present* this platform enablement for review. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110933): https://edk2.groups.io/g/devel/message/110933 Mute This Topic: https://groups.io/mt/102413902/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
