[AMD Official Use Only - General] One comment below,
> -----Original Message----- > From: Mike Maslenkin <mike.maslen...@gmail.com> > Sent: Wednesday, February 21, 2024 8:13 AM > To: devel@edk2.groups.io > Cc: Mike Maslenkin <mike.maslen...@gmail.com>; Igor Kulchytskyy > <ig...@ami.com>; Nickle Wang <nick...@nvidia.com>; Chang, Abner > <abner.ch...@amd.com> > Subject: [PATCH 1/4] RedfishClientPkg/RedfishFeatureUtilityLib: fix memory > leak on error path > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > Cc: Igor Kulchytskyy <ig...@ami.com> > Cc: Nickle Wang <nick...@nvidia.com> > Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> > Reviewed-by: Abner Chang <abner.ch...@amd.com> I think my name should be in "Cc:"? Abner > --- > .../Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib. > c > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib. > c > index e1494471038c..21ce8ddad9d5 100644 > --- > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib. > c > +++ > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib. > c > @@ -4010,6 +4010,7 @@ RedfishRemoveUnchangeableProperties ( > (RedfishCS_uint32)AsciiStrSize (*JsonString) > > ); > > if (Status != RedfishCS_status_success) { > > + FreePool (UpdatedJsonString); > > return EFI_DEVICE_ERROR; > > } > > > > -- > 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115697): https://edk2.groups.io/g/devel/message/115697 Mute This Topic: https://groups.io/mt/104479571/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-