[AMD Official Use Only - General]
Reviewed-by: Abner Chang <abner.ch...@amd.com>
> -----Original Message-----
> From: Mike Maslenkin <mike.maslen...@gmail.com>
> Sent: Wednesday, February 21, 2024 8:13 AM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin <mike.maslen...@gmail.com>; Chang, Abner
> <abner.ch...@amd.com>; Nickle Wang <nick...@nvidia.com>; Igor
> Kulchytskyy <ig...@ami.com>
> Subject: [PATCH 3/4] RedfishClientPkg/Bios: fix leak of GetPendingSettings
> URI.
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Cc: Abner Chang <abner.ch...@amd.com>
> Cc: Nickle Wang <nick...@nvidia.com>
> Cc: Igor Kulchytskyy <ig...@ami.com>
> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com>
> ---
> RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> index 396ec22969b5..8548425c9c83 100644
> --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> @@ -132,6 +132,7 @@ RedfishResourceConsumeResource (
> // Check and see if "@Redfish.Settings" exist or not.
>
> //
>
> ZeroMem (&PendingSettingResponse, sizeof (REDFISH_RESPONSE));
>
> + PendingSettingUri = NULL;
>
> Status = GetPendingSettings (
>
> Private->RedfishService,
>
> Response.Payload,
>
> @@ -206,6 +207,10 @@ RedfishResourceConsumeResource (
> FreePool (Etag);
>
> }
>
>
>
> + if (PendingSettingUri != NULL) {
>
> + FreePool (PendingSettingUri);
>
> + }
>
> +
>
> return Status;
>
> }
>
>
>
> --
> 2.32.0 (Apple Git-132)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115698): https://edk2.groups.io/g/devel/message/115698
Mute This Topic: https://groups.io/mt/104479573/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
