On Wed, 8 May 2024 at 11:07, Ard Biesheuvel <a...@kernel.org> wrote: > > On Wed, 8 May 2024 at 10:52, Pete Batard <p...@akeo.ie> wrote: > > > > Commit 80bbea192aa44ab664ba8be29ac06c83f246e99c introduced a regression > > resulting in 'error A2023: undefined symbol: InternalAssertJumpBuffer' > > when compling MdePkg for AARCH64 with Visual Studio. > > Fix this by adding the relevant EXTERN reference. > > > > Signed-off-by: Pete Batard <p...@akeo.ie> > > Cc: Leif Lindholm <quic_llind...@quicinc.com> > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > > Reviewed-by: Ard Biesheuvel <a...@kernel.org> > > Note that the same issue has been raised two months ago, and a similar > fix proposed > > https://openfw.io/edk2-devel/20240320025130.599086-1-adam....@tw.synaptics.com/ > > so IMHO this qualifies for inclusion in the stable tag. >
BTW the existence of this issue appears to imply that the VS RELEASE build does not #define MDEPKG_NDEBUG. Is that an oversight? > > > --- > > MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm > > b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm > > index 6ec8f35f2c9f..fa161e25f517 100644 > > --- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm > > +++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm > > @@ -7,6 +7,7 @@ > > > > EXPORT SetJump > > EXPORT InternalLongJump > > + EXTERN InternalAssertJumpBuffer > > AREA BaseLib_LowLevel, CODE, READONLY > > > > #define GPR_LAYOUT \ > > -- > > 2.45.0.windows.1 > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118668): https://edk2.groups.io/g/devel/message/118668 Mute This Topic: https://groups.io/mt/105977470/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
