Hi Prabin,

If you agree with my suggestions for patch 2/5, can you reply back on the list, please?

I will then fix that patch locally before merging.

Other than patch 2/5 the rest of the series looks good to me.

Reviewed-by: Sami Mujawar <sami.muaj...@arm.com>

Regards,

Sami Mujawar

On 4/3/24 18:33, Prabin CA wrote:
Each CPUs of RD-V2 has 64KB of L1 instruction/data cache, 2MB of L2
cache and 32MB of system level cache. The system architecture of the
RD-V2 platform is similar to the RD-N2 platform, except for the CPU
and L2 cache size. So existing RD-N2 SMBIOS support is extended for
RD-V2 platform to reuse rest of the RD-N2 SMBIOS configuration for the
RD-V2 platform.

Each CPUs of RD-Fremont include 64KB L1 instruction/data cache, 2MB L2
cache and 2MB of system level cache. This patch series adding the
extended SMBIOS support for RD-Fremont platform.

In addition to patches that extend the SMBIO support for these two
platforms, there are two patches that update support for existing
platforms. The first patch in this series introduce a PCD to specify
L2 cache size. The second patch make use of this PCD in PPTT table.

Link to gitlab branch with the patches in this series -
https://gitlab.arm.com/infra-solutions/reference-design/platsw/edk2-platforms/-/commits/topics/rdv2/?ref_type=heads

Prabin CA (3):
   Platform/Sgi: Add a new PCD for L2 cache size
   Platform/Sgi: Use PCD value for L2 cache size in PPTT table
   Platform/Sgi: Extend SMBIOS support for RD-Fremont

Pranav Madhu (2):
   Platform/Sgi: Define RD-V2 platform id values
   Platform/Sgi: Extend SMBIOS support for RD-V2 platform

  Platform/ARM/SgiPkg/SgiPlatform.dec                                       |  
3 +++
  Platform/ARM/SgiPkg/RdN2/RdN2.dsc                                         |  
4 ++++
  Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf                         |  
1 +
  Platform/ARM/SgiPkg/Include/SgiPlatform.h                                 | 
12 ++++++++++-
  Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c    | 
10 ++++++++--
  Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c | 
12 ++++++++---
  Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c     | 
21 +++++++++++++++++++-
  Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c                     | 
14 ++++++++++++-
  Platform/ARM/SgiPkg/AcpiTables/RdN2/Pptt.aslc                             |  
4 +++-
  9 files changed, 72 insertions(+), 9 deletions(-)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119477): https://edk2.groups.io/g/devel/message/119477
Mute This Topic: https://groups.io/mt/105313647/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to