> ----- Original Message ----- From: "Martin Conte Mac Donell"
>> I'm just visiting here since i've got an insanely amount of work, but >> i'v two comments. >> >> 1) Eclipse?, really? yep, Eclipse Ganymede with CDT 5.x. What else? ;) >> 2) I'm not pretty sure about "if (trans->port != 80)", it'll work fine >> in most cases but there is a border case when it'll not (Yeah, i know. >> I'm anal), the case is when you are going through ssl by port 80 (Yeah >> ok, shouldn't happen but you never know). I think the safest way is >> append port number always, it won't hurt anyway. That's no issue, since we handle both schemes, AND the port is passed from the HTTPServer trans struct. Which means if the "previous" call was 'https://foobar:80/xyz', and we get '/abc' as Location response (HTTP 302), we would still set in the recover_absolute_uri() function: 'https://foobar:80/abc'. So this still works normally. What I wanted to care about with the if statement is the "normal case", with default port 80, and reduce the load by avoiding the octstr format function and the later re-parsing. Stipe -- ------------------------------------------------------------------- Kölner Landstrasse 419 40589 Düsseldorf, NRW, Germany tolj.org system architecture Kannel Software Foundation (KSF) http://www.tolj.org/ http://www.kannel.org/ mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org -------------------------------------------------------------------
