Re: Patch: gw/urltrans.c

[Nikos Balkanas]

Added some needed initialization. Sorry about that.

BR,
Nikos

To: <devel@kannel.org>

Sent: Friday, August 27, 2010 1:30 AM
Subject: Re: Patch: gw/urltrans.c

----- Original Message ----- From: "Nikos Balkanas" <nbalka...@gmail.com> Cc: "Rene Kluwen" <rene.klu...@chimit.nl>; "'Alvaro Cornejo'" <cornejo.alv...@gmail.com>

Case insensitivity is observed in the code. It just lacks in configuration.

I changed patch to match documentation:

1) When given both keyword-regex and keyword, it will just prefer
keyword-regex without complains (according to UG).
2) It will accept any case in configuration for both keyword and
keyword-regex and do case incensitive matching.
3) Fixed a diagnostic that was pooping up evrywhere during matches.

Enjoy,
Nikos

To: "'Alvaro Cornejo'" <cornejo.alv...@gmail.com>; "'Nikos Balkanas'"
<nbalka...@gmail.com>
Cc: <devel@kannel.org>
Sent: Thursday, August 26, 2010 5:10 PM
Subject: RE: Patch: gw/urltrans.c


A lot of hand sets, nowadays automatically convert the first letter to
uppercase whilst typing an sms message.

So I think case-insensivity is not a bad thing?

== Rene

-----Original Message-----
From: devel-boun...@kannel.org [mailto:devel-boun...@kannel.org] On Behalf
Of Alvaro Cornejo
Sent: Thursday, 26 August, 2010 15:44
To: Nikos Balkanas
Cc: devel@kannel.org
Subject: Re: Patch: gw/urltrans.c

It should then be noted in the user guide. Otherwise we will continue
receiving this questions over and over.

|---------------------------------------------------------------------------
--------------------------------------|
Envνe y Reciba Datos y mensajes de Texto (SMS) hacia y desde cualquier
celular y Nextel
en el Perϊ, Mιxico y en mas de 180 paises. Use aplicaciones 2 vias via
SMS y GPRS online
Visitenos en www.perusms.NET www.smsglobal.com.mx y
www.pravcom.com



2010/8/26 Nikos Balkanas <nbalka...@gmail.com>:

----- Original Message ----- From: "Rene Kluwen" <rene.klu...@chimit.nl>

I don't know if this is really necessary. Just using lower case in the
keyword-regex pattern will work as well. Please disregard.

BR,
Nikos
----- Original Message ----- From: "Nikos Balkanas" <nbalka...@gmail.com>
To: <devel@kannel.org>
Sent: Thursday, August 26, 2010 8:02 AM
Subject: Patch: gw/urltrans.c

Hi,


is
in contrast to keyword matching, which is case incensitive. Additionaly,
input string input string is converted to lower case for matching. This
will
cause all keyword-regex patterns with capital letters to fail.

This patch corrects that by inittializing keyword-regex to case
incensitive
matching.
Reported by Mike Cariotoglou

BR,
Nikos

Currently keyword-regex is configured to only do exact case matches. This

urltrans.diff
Description: Binary data