On 2017-11-06 06:13, David Tardon wrote:
> I will build a new release of poppler this week, which includes soname
> bump. I will take care of rebuilding the affected packages:

While ultimately it would be nice to have everything use one of the
bindings as intended, but in the meantime perhaps we can still save you
some work for the next bump.

> kf5-kfilemetadata
> okular

These are cases of overlinking, as they only use symbols from
libpoppler-qt5.  This can be seen in Ubuntu (which links with
-Wl,--as-needed and -Wl,--no-undefined) and Cygwin (which as a PE
platform acts similarly automatically), neither of which require libpoppler.

extra-cmake-modules should be fixed so that Poppler::Qt5 does not pull
in Poppler::Core:

--- a/find-modules/FindPoppler.cmake
+++ b/find-modules/FindPoppler.cmake
@@ -86,5 +86,4 @@
 foreach(_comp ${Poppler_known_components})
     string(TOLOWER "${_comp}" _lc_comp)
-    set(Poppler_${_comp}_component_deps "Core")
     set(Poppler_${_comp}_pkg_config "poppler-${_lc_comp}")
     set(Poppler_${_comp}_lib "poppler-${_lc_comp}")

> poppler-sharp

Are you sure this is necessary?  Only libpoppler-glib is mentioned in
the .dll.config, and libpoppler doesn't have a C API for the assembly to
load.

> texworks

This too appears to be a case of overlinking, and again neither Ubuntu
or Cygwin show a libpoppler dependency, and Debian's build log shows a
warning that it is unused.  POPPLER_BASE_LIBRARIES is used in
modules/QtPDF/CMake/Modules/FindPoppler.cmake (no relation to ECM's) to
determine if poppler was built with fontconfig support, but if you
remove it from POPPLER_LIBRARIES there it should avoid this.

-- 
Yaakov Selkowitz
Software Engineer - Platform Enablement Group
Red Hat, Inc.

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Reply via email to