Hi,

great to see someone taking up on some rubygems!

to the packages, the rubygem-linked-list as mentioned by Fabio have binaries that will probably have name conflicts with some other packages.

Secondly rubygem-hrx should not have `Requires: rubygem(linked-list)`[0] because that dependency is automatically generated from package's gemspec. So rubygem-thor will get pulled in as well as a result.

I highly recommend running the test suite in %check section[1], since ruby cannot catch some basic stuff at compile time (because there is no compilation :) ) unlike with let's say Java.

Also I think you can submit package review requests with the state it is in and there we can help you with each package in their own bug threads, even if you have no experience.

Cheers,

Jarek


[0] https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/#_rubygems

[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/#_running_test_suites

On 03/12/2019 19:08, Leigh Scott wrote:
Hi,

Can someone  check these specfiles before I submit review requests please?
I have zero experience with packaging rubygem packaes.

https://leigh123linux.fedorapeople.org/pub/SPECS/rubygem-hrx.spec
https://leigh123linux.fedorapeople.org/pub/SPECS/rubygem-linked-list.spec

Best regards
Leigh
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Reply via email to