Hi Leigh, Thank you for contributing the rubygem-* packages. Let me comment for your *.spec files.
I recommend to compare the *.spec file generated by gem2rpm with your *.spec file, and align basically. The gem2rpm guides you. How to do it (For example in case of Fedora 30) ``` $ sudo dnf install rubygem-gem2rpm $ rpm -q rubygem-gem2rpm rubygem-gem2rpm-1.0.1-3.fc30.noarch $ gem fetch hrx $ ls -l hrx-1.0.0.gem $ gem2rpm hrx-1.0.0.gem > rubygem-hrx.spec ``` If you find some improvements for generated spec file, you can report it here. https://github.com/fedora-ruby/gem2rpm 2. Adding %check section, as Jaroslav said. Note that we do not use "bundler" ("bundle" command) and "rake" command in RPM *.spec file. 3. Following *.spec files might be useful to refer. https://src.fedoraproject.org/rpms/rubygem-listen/blob/master/f/rubygem-listen.spec with Ruby C-extention. https://src.fedoraproject.org/rpms/rubygem-rake/blob/master/f/rubygem-rake.spec without Ruby C-extension. "gem unpack" is useful to see the files in the *.gem file. As hrx-1.0.0.gem and linked-list-0.0.13.gem are including the unit test files in it, Possibly "Source0" is good enough. Note above 2 *.spec files use "Source1" too, as gem file does not include the unit test files. ``` $ gem unpack hrx-1.0.0.gem Unpacked gem: '/home/jaruga/doc/memo/20191203_review_rubygem_pkgs/hrx-1.0.0' ``` Happy building! -- Jun | He - His - Him _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
