On 19. 04. 20 18:01, Jerry James wrote:
On Sun, Apr 19, 2020 at 10:00 AM Miro Hrončok <mhron...@redhat.com> wrote:
On 19. 04. 20 17:49, Miro Hrončok wrote:
On 19. 04. 20 17:09, Miro Hrončok wrote:
I'll send a PR shortly.
Finishing the commit message...
https://src.fedoraproject.org/rpms/python-nb2plots/pull-request/2
Thank you!
You are welcome and sorry for the trouble with the broken generator -- although
it uncovered a problem in nb2plots.
As a side note I must say I really dislike how versioneer hardcodes the version
information in the file with bundled copy of versioneer itself.
There is at least https://github.com/warner/python-versioneer/issues/199 for
environment variable support.
But latest commit in the project is from 2017.
If you have close relationship with nb2plots upstream, please consider
suggesting them to switch to setuptools-scm, the de-facto standard to do what
versioneer is doing (however I don't know the history, maybe they have chosen
versioneer over setuptools-scm for a reason).
--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
