-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On Tue, 2020-06-16 at 02:21 +0200, Kevin Kofler wrote:
> Ben Cotton wrote:
> > == Summary ==
> > <code>%cmake</code> macro will be adjusted (<code>-B</code>
> > parameter)
> > to use separate build folder (already standardized
> > <code>%{_vpath_builddir}</code> macro). Additionally,
> > <code>%cmake_build</code>, <code>%cmake_install</code> and
> > <code>%ctest</code> macro will be created (and backported to the
> > older
> > supported Fedora releases) to perform various operations that are
> > commonly used with CMake in a backend-agnostic (Makefiles, Ninja,
> > etc.) way.
> > 
> > Packages that will stop building are trivial to fix and will be
> > adjusted either by maintainers or change owners.
> > 
> > == Owner ==
> > * Name: [[User:ignatenkobrain|Igor Raits]], [[User:besser82|Björn
> > Esser]], [[User:ngompa|Neal Gompa]]
> > * Email: ignatenkobr...@fedoraproject.org, 
> > besse...@fedoraproject.org,
> > ngomp...@gmail.com
> 
> How does this affect the many packages that already build in a
> separate 
> build folder manually? There are even several specfile templates that
> contain the boilerplate for that.

If they assume that builddir will be in `.`, they will break. And we
will fix them.

To prevent breaking, it is enough to specify `-B .` or setting
`%{_vpath_builddir}` to `.`.

> And why is it worth making a potentially incompatible change to the
> %cmake 
> macro when it can already be done with the existing one?

Not sure if I follow, what means "can already be done with the existing
one"? Does it mean that you can already specify a build dir via CLI and
some packages already do (e.g. libsolv)?
> 
>         Kevin Kofler
> _______________________________________________
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct:  
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines:  
> https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:  
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
- -- 
Igor Raits <ignatenkobr...@fedoraproject.org>
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEcwgJ58gsbV5f5dMcEV1auJxcHh4FAl7oVDMACgkQEV1auJxc
Hh6eAA//Zcu6swqz5QBUW/Tof+UrTZrYYSVomGuqp7ramJFlDjEOT2Vi8turzz+a
WUkFp3ITGml9W324Y75+TMq9nAnoAwiuEjhnknEQ1aO+U5n9wiCRQx+t0Gtw8sHT
BsP+vu1FbXVN9NgQxmVXfKlD4yB6JAzU1XvVF8szXpHpiJEA3fstMf4wtCJkWRNa
3jHpByUsLijgYoddTO/DCdqIBOtXUhoEHfm98ZmLI4rBvF85vAA67ylcKuWjXHNw
OKtVnTOYBxP16XLEQuP4MyjeZDcBbWxJgAWfaEE4ozhV+D8zRKYAuiRVi29ANJN/
D3QxwZVjMIOyPciT7yrurApP+njMsf58MNs5jVdW2PZX2Kx2unU0ojv+01jBz5qs
hYDlKTmk+zvYrLtG30HXSSoe+WuO2pzeQPAKrCODm89fteyzOfj0ZHW7j02vB/7O
d3WIw9KpKbvBdxTVlfL4aEBxvm3WXfjW2zcXCSCmxUHCX9Hs5pDqOK5KOHpdxWj5
n3msgjAJrF8Vap2cqPwWcbX0plyrKiTHspQuD5mj9j1jG9VjPK6ynNvmrzXJMn0D
wxrkJBA3FpLtNhI7XOdlHPKWVuiwVV369NKkavgKY3ea2QzHGJsnPOaaVoXCtMNl
90pSjpLh1jTntN0VlMMXN3pJaoC+QZw7i76WQJ6wIYp0VKN9j5E=
=SoZw
-----END PGP SIGNATURE-----
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Reply via email to