-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On Tue, 2020-06-16 at 03:47 +0200, Kevin Kofler wrote: > Neal Gompa wrote: > > If they build a separate folder manually and are already using the > > VPATH macros, then there's no change. If they're using a different > > structure, we can adapt them to the standard VPATH macros, and do > > other adjustments as needed. > > The common idiom in KDE packages is: > mkdir %{_target_platform} > pushd %{_target_platform} > %{cmake_kf5} .. > popd > > So: > 1. Are you going to apply this change also to %{cmake_kf5} or just > plain > %cmake?
I've just updated the change page that clarifies this question. I'm also surprised that %cmake_kf5 does not use %cmake, but we are not going to change this as part of this proposal and leave it for anybody else who might want to work on that. > 2. If a construct like this is used, I guess we will end up with a > VPATH > inside %{_target_platform}? So the -debugsource package will have > a > nested structure like Russian matrioshka puppets or Chinese boxes? > > > Defaults matter. And upstreams complain about us not doing out of > > tree > > builds by default. Some projects even intentionally break in-source > > builds and packagers shouldn't struggle to figure out how to do the > > right thing in that circumstance. > > It is unfortunate that some upstreams (including parts of KDE) are > doing > this. This is a very pointless and unhelpful thing to do. I see no > benefit > from disallowing in-source builds, it is just a simple special case > and > normally requires no extra code to support. > > Kevin Kofler > _______________________________________________ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: > https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org - -- Igor Raits <ignatenkobr...@fedoraproject.org> -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcwgJ58gsbV5f5dMcEV1auJxcHh4FAl7oxS4ACgkQEV1auJxc Hh6VGA/8DTF4GLhj8yAJVQNn3JA7UyrYKlx89aHpxCQVtJg3SqbnwvZVHwrl2LHx cDhnbYt7KmzGkVkG3iapdROBXFED80zXaGm4BAOZF9YXUQyphpaker4NkIyjfksx GE2bD77ZlzP+5bBnSWSkJ6zJtdxVf7KK81V7jOV0tD2DkDJp6VjBvJJZ009PKZha Exe5cr1bbALT6+j4IQTjTZOAiqxpQPZasb9/5VXz7G+J79ATv3kBpueoJpShba/t BcTzdUVihBll5jS6BJQkFUhdfjb1kjZ4YndZ7aPSPnpNJFumYEyfkKrm+yIjlkA2 aaSL5Yy0RjHB8k+Sixftvc2sCjbtU6QhRYOOyxYpXXiHnHrev09YD+H2CzR8/FMf e829Epm2eUDmKA4JEuCWNTwpRS+KZ+ga35GhVWsBzFecSQT8pGaz2Bu9teKZevR0 pnAzlxKt6VnXBHRWj1DtcoNUQbkDNI3/Nu25XwY3GsR/jjYNUl7Z6/UgtJmuodLL 1AZ3P9okMFofcevkD5rI+QPAG2SfEOGZd4ONZBZ9PP3w1gDWM0T0BojFGXYhZ19d GGxlYvYKf0pmcAiKuoERJ8JFKC8HFYR6Nj2MzLX4odGHAkwAdaeht1LvZVkgNeDb Ptt0GmxIUt0i6swjXgVvvIQH1G4fTsupXd6ZTgPwQzWNvXosoc4= =qwEu -----END PGP SIGNATURE----- _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org