On Thu, Dec 3, 2020 at 10:22 AM Gary Buhrmaster <gary.buhrmas...@gmail.com> wrote:
> On Thu, Dec 3, 2020 at 3:39 PM Fabio Valentini <decatho...@gmail.com> > wrote: > > > I still think a lot of those are "false positives". > > CMake has a hard Requires on make, so if I BuildRequires cmake, adding > > "BuildRequires: make" is just redundant. > > https://src.fedoraproject.org/rpms/cmake/blob/master/f/cmake.spec#_185 > > I think this was discussed previously, but > while cmake may have a requires on make > today, cmake can now use ninja rather > than make in at least some cases, so one > should certainly not presume cmake will > always require make. If the build requires > make, it should call it out explicitly. > I think here is a RARE instance we disagree :) Presumably everyone is using the %cmake / %cmake_build / %cmake_install macros. If so and the current default for cmake is to use make, and cmake has a hard dep on make, then why add the extra BR? If the *default* is changed to ninja at some point I would expect for cmake to have a hard dep on ninja. If you're not using the macros or overriding the default then you're already on your own and should BR make or ninja (or whatever) anyway. Thanks, Richard > _______________________________________________ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org >
_______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
