Jan Kaluža wrote:
On 01/15/2014 01:56 AM, Todd Zullinger wrote:
<mock-chroot>[root@f20-64 /]# /usr/lib/rpm/find-requires <<< /builddir/build/BUILD/git-1.8.4.2/git-svn

This fails because find-requires only passes the file to perl.req if it's either a .pm file or it's in the script list, which is defined like this:

scriptlist=`echo $filelist | xargs -r file | \ grep -E ":.* (commands|script)[, ]" | cut -d: -f1`

Thanks for this part. I didn't know that. My test-suite for File checks only the regexp defined in /usr/lib/rpm/fileattrs, which is following in F20:

%__perl_magic           ^.*[Pp]erl .*$

So when testing File-5.14 I didn't think this will cause problems to RPM. I can make File to return "Perl script" again, but I would rather stay consistent with upstream in the detection.

There's already bug about this: <https://bugzilla.redhat.com/show_bug.cgi?id=1051598>. I will open upstream bug for that.

Thanks Jan.  I'll follow that bug.

--
Todd        OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Be it our wealth, our jobs, or even our homes; nothing is safe while
the legislature is in session.

Attachment: pgpL_eL0tyg8N.pgp
Description: PGP signature

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Reply via email to